Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758786AbbEFDfT (ORCPT ); Tue, 5 May 2015 23:35:19 -0400 Received: from mail-wg0-f67.google.com ([74.125.82.67]:33245 "EHLO mail-wg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757732AbbEFDfR (ORCPT ); Tue, 5 May 2015 23:35:17 -0400 From: Ingo Molnar X-Google-Original-From: Ingo Molnar Date: Wed, 6 May 2015 05:35:13 +0200 To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, Andy Lutomirski , Dave Hansen , Fenghua Yu , "H. Peter Anvin" , Linus Torvalds , Oleg Nesterov , Thomas Gleixner Subject: Re: [PATCH 206/208] x86/fpu: Add CONFIG_X86_DEBUG_FPU=y FPU debugging code Message-ID: <20150506033513.GA12051@gmail.com> References: <1430848712-28064-1-git-send-email-mingo@kernel.org> <1430848712-28064-46-git-send-email-mingo@kernel.org> <20150505194116.GR3910@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150505194116.GR3910@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2221 Lines: 63 * Borislav Petkov wrote: > On Tue, May 05, 2015 at 07:58:30PM +0200, Ingo Molnar wrote: > > There are various internal FPU state debugging checks that never > > trigger in practice, but which are useful for FPU code development. > > > > Separate these out into CONFIG_X86_DEBUG_FPU=y, and also add a > > couple of new ones. > > > > The size difference is about 0.5K of code on defconfig: > > > > text data bss filename > > 15028906 2578816 1638400 vmlinux > > 15029430 2578816 1638400 vmlinux > > > > ( Keep this enabled by default until the new FPU code is debugged. ) > > > > Cc: Andy Lutomirski > > Cc: Borislav Petkov > > Cc: Dave Hansen > > Cc: Fenghua Yu > > Cc: H. Peter Anvin > > Cc: Linus Torvalds > > Cc: Oleg Nesterov > > Cc: Thomas Gleixner > > Signed-off-by: Ingo Molnar > > ... > > > diff --git a/arch/x86/include/asm/fpu/internal.h b/arch/x86/include/asm/fpu/internal.h > > index a4c1b7dbf70e..d2a281bd5f45 100644 > > --- a/arch/x86/include/asm/fpu/internal.h > > +++ b/arch/x86/include/asm/fpu/internal.h > > @@ -59,6 +59,15 @@ extern void fpu__clear(struct fpu *fpu); > > extern void fpu__init_check_bugs(void); > > extern void fpu__resume_cpu(void); > > > > +/* > > + * Debugging facility: > > + */ > > +#ifdef CONFIG_X86_DEBUG_FPU > > +# define WARN_ON_FPU(x) WARN_ON_ONCE(x) > > +#else > > +# define WARN_ON_FPU(x) ({ 0; }) > > Shouldn't this be called FPU_WARN_ON() ? So I wanted this to match the 'usual' WARN*() APIs in appearance, with only at the end a small signal that this is conditional on FPU debugging enabled. In terms of code, we should think of them as WARN_ON()s. Slapping FPU_ in front of them distracts from that IMHO. No strong feelings though. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/