Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758924AbbEFEOF (ORCPT ); Wed, 6 May 2015 00:14:05 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:10567 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758909AbbEFEOA (ORCPT ); Wed, 6 May 2015 00:14:00 -0400 Message-ID: <554994E6.2040900@huawei.com> Date: Wed, 6 May 2015 12:13:26 +0800 From: Hou Pengyang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Will Deacon CC: "a.p.zijlstra@chello.nl" , "paulus@samba.org" , "acme@kernel.org" , "mingo@redhat.com" , "wangnan0@huawei.com" , "Catalin Marinas" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 2/2] arm64: perf: Fix callchain parse error with kernel tracepoint events References: <1430546297-80481-1-git-send-email-houpengyang@huawei.com> <1430546297-80481-3-git-send-email-houpengyang@huawei.com> <20150505170006.GM1550@arm.com> In-Reply-To: <20150505170006.GM1550@arm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.95.59] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.55499500.0071,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: cc2c4736c24678ab2fe52601cd604e80 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3300 Lines: 84 On 2015/5/6 1:00, Will Deacon wrote: > On Sat, May 02, 2015 at 06:58:17AM +0100, Hou Pengyang wrote: >> For ARM64, when tracing with tracepoint events, the IP and pstate are set >> to 0, preventing the perf code parsing the callchain and resolving the >> symbols correctly. >> >> ./perf record -e sched:sched_switch -g --call-graph dwarf ls >> [ perf record: Captured and wrote 0.146 MB perf.data ] >> ./perf report -f >> Samples: 194 of event 'sched:sched_switch', Event count (approx.): 194 >> Children Self Command Shared Object Symbol >> 100.00% 100.00% ls [unknown] [.] 0000000000000000 >> >> The fix is to implement perf_arch_fetch_caller_regs for ARM64, which fills >> several necessary registers used for callchain unwinding, including pc,sp, >> fp and spsr . >> >> With this patch, callchain can be parsed correctly as follows: >> >> ...... >> + 2.63% 0.00% ls [kernel.kallsyms] [k] vfs_symlink >> + 2.63% 0.00% ls [kernel.kallsyms] [k] follow_down >> + 2.63% 0.00% ls [kernel.kallsyms] [k] pfkey_get >> + 2.63% 0.00% ls [kernel.kallsyms] [k] do_execveat_common.isra.33 >> - 2.63% 0.00% ls [kernel.kallsyms] [k] pfkey_send_policy_notify >> pfkey_send_policy_notify >> pfkey_get >> v9fs_vfs_rename >> page_follow_link_light >> link_path_walk >> el0_svc_naked >> ....... >> >> Signed-off-by: Hou Pengyang >> --- >> arch/arm64/include/asm/perf_event.h | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm64/include/asm/perf_event.h b/arch/arm64/include/asm/perf_event.h >> index d26d1d5..cc92021 100644 >> --- a/arch/arm64/include/asm/perf_event.h >> +++ b/arch/arm64/include/asm/perf_event.h >> @@ -24,4 +24,11 @@ extern unsigned long perf_misc_flags(struct pt_regs *regs); >> #define perf_misc_flags(regs) perf_misc_flags(regs) >> #endif >> >> +#define perf_arch_fetch_caller_regs(regs, __ip) { \ >> + (regs)->ARM_pc = (__ip); \ >> + (regs)->ARM_fp = (unsigned long) __builtin_frame_address(0); \ >> + (regs)->ARM_sp = current_stack_pointer; \ >> + (regs)->ARM_cpsr = PSR_MODE_EL1h; \ >> +} > > This can't possibly compile, therefore you can't possibly have tested it. > I am so sorry. I did test the patch, but on mainline 4.0 + David long's patches for ARM64 kprobe which are not included in mainline now. In David's patches, there are macros like ARM_pc, ARM_fp, ARM_sp and ARM_cpsr, my patch incorrectly used these macros which results in such compile errors if applied to 4.0 directly: error: 'struct pt_regs' has no member named 'ARM_pc' error: 'struct pt_regs' has no member named 'ARM_fp' error: 'struct pt_regs' has no member named 'ARM_sp' error: 'struct pt_regs' has no member named 'ARM_cpsr' I will fix the code and do more test. > Please fix the code and actually check that you're getting sensible > callchains before sending a new version of the patch. > > Thanks, > > Will > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/