Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758907AbbEFENo (ORCPT ); Wed, 6 May 2015 00:13:44 -0400 Received: from mail-wi0-f193.google.com ([209.85.212.193]:32783 "EHLO mail-wi0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbbEFENn (ORCPT ); Wed, 6 May 2015 00:13:43 -0400 From: Ingo Molnar X-Google-Original-From: Ingo Molnar Date: Wed, 6 May 2015 06:13:39 +0200 To: "Yu, Fenghua" Cc: "linux-kernel@vger.kernel.org" , Andy Lutomirski , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Linus Torvalds , Oleg Nesterov , Thomas Gleixner Subject: Re: [PATCH 200/208] x86/fpu/xstate: Don't assume the first zero xfeatures zero bit means the end Message-ID: <20150506041339.GA12174@gmail.com> References: <1430848712-28064-1-git-send-email-mingo@kernel.org> <1430848712-28064-40-git-send-email-mingo@kernel.org> <3E5A0FA7E9CA944F9D5414FEC6C712205C8D629F@ORSMSX106.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E5A0FA7E9CA944F9D5414FEC6C712205C8D629F@ORSMSX106.amr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1268 Lines: 30 * Yu, Fenghua wrote: > > From: Ingo Molnar [mailto:mingo.kernel.org@gmail.com] On Behalf Of Ingo > > Molnar > > Sent: Tuesday, May 05, 2015 10:58 AM > > To: linux-kernel@vger.kernel.org > > Cc: Andy Lutomirski; Borislav Petkov; Dave Hansen; Yu, Fenghua; H. Peter > > Anvin; Linus Torvalds; Oleg Nesterov; Thomas Gleixner > > Subject: [PATCH 200/208] x86/fpu/xstate: Don't assume the first zero > > xfeatures zero bit means the end > > > > The current xstate code in setup_xstate_features() assumes that the first > > zero bit means the end of xfeatures - but that is not so, the SDM clearly > > states that an arbitrary set of xfeatures might be enabled - and it is also clear > > from the description of the compaction feature that holes are possible: > > A previous patch in lkml has (exactly) the same fix: > http://lists-archives.com/linux-kernel/28292115-x86-xsave-c-fix-xstate-offsets-and-sizes-enumeration.html Ok, and that series has some more bits as well - will merge. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/