Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754058AbbEFFSJ (ORCPT ); Wed, 6 May 2015 01:18:09 -0400 Received: from mga11.intel.com ([192.55.52.93]:37364 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752414AbbEFFSG (ORCPT ); Wed, 6 May 2015 01:18:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,378,1427785200"; d="scan'208";a="690600809" Message-ID: <5549A402.2010007@linux.intel.com> Date: Wed, 06 May 2015 13:17:54 +0800 From: Jiang Liu Organization: Intel User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Thomas Gleixner CC: Bjorn Helgaas , Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Randy Dunlap , Yinghai Lu , Borislav Petkov , Dimitri Sivanich , Jonathan Corbet , x86@kernel.org, Konrad Rzeszutek Wilk , David Cohen , Sander Eikelenboom , David Vrabel , Andrew Morton , Tony Luck , Joerg Roedel , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Daniel J Blueman , linux-doc@vger.kernel.org Subject: Re: [Patch 2/2] x86, irq: Support CPU vector allocation policies References: <1430707662-28598-1-git-send-email-jiang.liu@linux.intel.com> <1430707662-28598-3-git-send-email-jiang.liu@linux.intel.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2040 Lines: 58 On 2015/5/6 3:25, Thomas Gleixner wrote: > On Mon, 4 May 2015, Jiang Liu wrote: >> +enum { >> + /* Allocate CPU vectors from CPUs on device local node */ >> + X86_VECTOR_POL_NODE = 0x1, >> + /* Allocate CPU vectors from all online CPUs */ >> + X86_VECTOR_POL_GLOBAL = 0x2, >> + /* Allocate CPU vectors from caller specified CPUs */ >> + X86_VECTOR_POL_CALLER = 0x4, >> + X86_VECTOR_POL_MIN = X86_VECTOR_POL_NODE, >> + X86_VECTOR_POL_MAX = X86_VECTOR_POL_CALLER, >> +} > >> +static unsigned int vector_alloc_policy = X86_VECTOR_POL_NODE | >> + X86_VECTOR_POL_GLOBAL | >> + X86_VECTOR_POL_CALLER; > >> +static int __init apic_parse_vector_policy(char *str) >> +{ >> + if (!strncmp(str, "node", 4)) >> + vector_alloc_policy |= X86_VECTOR_POL_NODE; > > This does not make sense. X86_VECTOR_POL_NODE is already set. > >> + else if (!strncmp(str, "global", 6)) >> + vector_alloc_policy &= ~X86_VECTOR_POL_NODE; > > Why would one disable node aware allocation? We fall back to the > global allocation anyway, if the node aware allocation fails. > > I'm completely missing the value of this command line option. Hi Thomas, You are right. Originally I want a method to disable the per-node allocation policy. Think it twice, it seems unnecessary at all. Enabling per-node allocation policy by default shouldn't cause serious issues, and user may change irq affinity setting if the default affinity isn't desired. So we don't need the kernel parameter at all. Will update the patch. Thanks! Gerry > > Thanks, > > tglx > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/