Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755456AbbEFFa3 (ORCPT ); Wed, 6 May 2015 01:30:29 -0400 Received: from mail-by2on0106.outbound.protection.outlook.com ([207.46.100.106]:5488 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755212AbbEFFa0 convert rfc822-to-8bit (ORCPT ); Wed, 6 May 2015 01:30:26 -0400 From: Ramneek Mehresh To: Alan Stern CC: Kernel development list , Felipe Balbi , USB list , "gregkh@linuxfoundation.org" Subject: RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver Thread-Topic: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver Thread-Index: AQHQh1uKl7mjiKlO10ShKrKkIr6ymp1txRAAgACnYmA= Date: Wed, 6 May 2015 05:30:23 +0000 Message-ID: References: <1430848716-32157-2-git-send-email-ramneek.mehresh@freescale.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: rowland.harvard.edu; dkim=none (message not signed) header.d=none; x-originating-ip: [192.88.169.1] x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB1583; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:SN1PR0301MB1583;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB1583; x-forefront-prvs: 0568F32D91 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(24454002)(13464003)(51704005)(110136002)(5001960100002)(189998001)(122556002)(76576001)(40100003)(19580405001)(46102003)(77156002)(62966003)(102836002)(19580395003)(2900100001)(2950100001)(54356999)(76176999)(50986999)(106116001)(74316001)(92566002)(87936001)(2171001)(2656002)(66066001)(86362001)(99286002)(33656002);DIR:OUT;SFP:1102;SCL:1;SRVR:SN1PR0301MB1583;H:SN1PR0301MB1583.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2015 05:30:23.5620 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1583 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 48 > -----Original Message----- > From: Alan Stern [mailto:stern@rowland.harvard.edu] > Sent: Wednesday, May 06, 2015 1:00 AM > To: Mehresh Ramneek-B31383 > Cc: Kernel development list; Felipe Balbi; USB list; > gregkh@linuxfoundation.org > Subject: Re: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb > host driver > > On Tue, 5 May 2015, Ramneek Mehresh wrote: > > > Add workqueue to add/remove host driver (outside interrupt context) > > upon each id change > > > > Signed-off-by: Ramneek Mehresh > > --- > > Changes for v3: > > - use overrides for ehci_fsl_overrides > > - remove struct ehci_hcd from ehci_fsl > > - move ehci_fsl to ehci-fsl.h > > This patch changes at least three separate things: > > It adds the workqueue stuff. > > It replaces ehci_fsl_hc_driver with ehci_fsl_overrides. > > It adds new fields into the overrides structure. > understood > A patch should do only one thing. It certainly shouldn't make three separate, > major changes! > > Also, I'm not going to let you add new fields into the ehci_driver_overrides > structure. If you really need to override other routines, copy the approach > used by ehci-tegra.c. > Understood...but I would appreciate if you could please explain the harm in doing so > Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/