Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755232AbbEFGAj (ORCPT ); Wed, 6 May 2015 02:00:39 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:35522 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755126AbbEFGAh (ORCPT ); Wed, 6 May 2015 02:00:37 -0400 Date: Tue, 5 May 2015 23:00:35 -0700 From: Darren Hart To: Azael Avalos Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] toshiba_acpi: Driver cleanup Message-ID: <20150506060035.GB7523@vmdeb7> References: <1430759758-4026-1-git-send-email-coproscefalo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430759758-4026-1-git-send-email-coproscefalo@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1798 Lines: 44 On Mon, May 04, 2015 at 11:15:53AM -0600, Azael Avalos wrote: > These patches cleanup the driver from some no longer needed > functions, renames hci_{read, write}1 functions, some comment > blocks were changed, unneeded error checks removed and the driver > version was bumped to 0.22. > > Changes since v1: > - Added two new patches to the series, one containing error check > removals and another bumping the driver version. > > Darren: > Sorry for this, I totally forgot to include the patch to remove > the function error check :-( > Now this patchset is complete now :-) > So I'm a little confused :-) I have staged the patches locally as follows (newest first): f6ea7d1 toshiba_acpi: Bump driver version to 0.22 dd8b682 toshiba_acpi: Remove TOS_FAILURE check from some functions 60d9349 toshiba_acpi: Cleanup blank lines after comment blocks c62377a toshiba_acpi: Rename hci_{read, write}1 functions cbed7e3 toshiba_acpi: Remove no longer needed hci_{read, write}2 functions 8f163a9 toshiba_acpi: Remove bluetooth rfkill code 0a4c28f toshiba_bluetooth: Change BT status message to debug 3ad2df6 toshiba_bluetooth: Adapt *_enable, *_notify and *_resume functions to rfkill 9eb4797 toshiba_bluetooth: Add RFKill handler functions 1ae8cb3 toshiba_bluetooth: Add a container struct named toshiba_bluetooth_dev ... Is this what you had in mind? As for the comment cleanup (blank lines, etc.). Joe raised some points, I think I did too - is there another version of that patch coming? -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/