Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755771AbbEFHYM (ORCPT ); Wed, 6 May 2015 03:24:12 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:43375 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119AbbEFHYJ (ORCPT ); Wed, 6 May 2015 03:24:09 -0400 Date: Wed, 6 May 2015 08:24:07 +0100 From: Al Viro To: NeilBrown Cc: Linus Torvalds , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 51/79] namei: remove restrictions on nesting depth Message-ID: <20150506072406.GX889@ZenIV.linux.org.uk> References: <20150505052205.GS889@ZenIV.linux.org.uk> <1430803373-4948-51-git-send-email-viro@ZenIV.linux.org.uk> <20150506125528.0be6d30e@notabene.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150506125528.0be6d30e@notabene.brown> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 690 Lines: 20 On Wed, May 06, 2015 at 12:55:28PM +1000, NeilBrown wrote: > > - if (unlikely(current->total_link_count >= 40)) { > > + if (unlikely(current->total_link_count >= MAXSYMLINKS)) { > > There is still a literal '40' in follow_automount. > > current->total_link_count++; > if (current->total_link_count >= 40) > return -ELOOP; > > > should that become MAXSYMLINKS too? Yes, assuming we want to keep it at all... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/