Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755866AbbEFHej (ORCPT ); Wed, 6 May 2015 03:34:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60116 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750769AbbEFHeh (ORCPT ); Wed, 6 May 2015 03:34:37 -0400 Date: Wed, 6 May 2015 09:34:32 +0200 From: Jan Kara To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Andrew Morton , Alexander Viro , Jan Kara Subject: Re: [PATCH 2/2 linux-next] AFFS: add tmpfile support Message-ID: <20150506073432.GC3872@quack.suse.cz> References: <1430849170-1171-1-git-send-email-fabf@skynet.be> <1430849170-1171-2-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430849170-1171-2-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2776 Lines: 88 On Tue 05-05-15 20:06:10, Fabian Frederick wrote: > Based on the following patch: > commit 60545d0d4610 ("[O_TMPFILE] it's still short a few helpers, > but infrastructure should be OK now...") > > Tested with xfstests generic/004 > > Cc: Andrew Morton > Cc: Alexander Viro > Cc: Jan Kara > Signed-off-by: Fabian Frederick The patch looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/affs/affs.h | 1 + > fs/affs/dir.c | 1 + > fs/affs/namei.c | 23 +++++++++++++++++++++++ > 3 files changed, 25 insertions(+) > > diff --git a/fs/affs/affs.h b/fs/affs/affs.h > index cffe837..c3f60a5 100644 > --- a/fs/affs/affs.h > +++ b/fs/affs/affs.h > @@ -180,6 +180,7 @@ extern int affs_rename(struct inode *old_dir, struct dentry *old_dentry, > extern unsigned long affs_parent_ino(struct inode *dir); > extern struct inode *affs_new_inode(struct inode *dir); > extern int affs_notify_change(struct dentry *dentry, struct iattr *attr); > +extern int affs_tmpfile(struct inode *dir, struct dentry *dentry, umode_t mode); > extern void affs_evict_inode(struct inode *inode); > extern struct inode *affs_iget(struct super_block *sb, > unsigned long ino); > diff --git a/fs/affs/dir.c b/fs/affs/dir.c > index ac4f318..2b0e5ea 100644 > --- a/fs/affs/dir.c > +++ b/fs/affs/dir.c > @@ -37,6 +37,7 @@ const struct inode_operations affs_dir_inode_operations = { > .rmdir = affs_rmdir, > .rename = affs_rename, > .setattr = affs_notify_change, > + .tmpfile = affs_tmpfile, > }; > > static int > diff --git a/fs/affs/namei.c b/fs/affs/namei.c > index b183540..7c3909a 100644 > --- a/fs/affs/namei.c > +++ b/fs/affs/namei.c > @@ -466,3 +466,26 @@ done: > affs_brelse(bh); > return retval; > } > + > +int affs_tmpfile(struct inode *dir, struct dentry *dentry, umode_t mode) > +{ > + > + struct super_block *sb = dir->i_sb; > + struct affs_sb_info *sbi = AFFS_SB(sb); > + struct inode *inode; > + > + inode = affs_new_inode(dir); > + if (!inode) > + return -ENOSPC; > + > + inode->i_mode = mode; > + mode_to_prot(inode); > + inode->i_mapping->a_ops = affs_test_opt(sbi->s_flags, SF_OFS) ? > + &affs_aops_ofs : &affs_aops; > + inode->i_op = &affs_file_inode_operations; > + inode->i_fop = &affs_file_operations; > + mark_inode_dirty(inode); > + d_tmpfile(dentry, inode); > + unlock_new_inode(inode); > + return 0; > +} > -- > 1.9.1 > -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/