Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752842AbbEFH7A (ORCPT ); Wed, 6 May 2015 03:59:00 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:19764 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbbEFH65 (ORCPT ); Wed, 6 May 2015 03:58:57 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-09-5549c9becd93 Message-id: <5549C9BD.8010903@samsung.com> Date: Wed, 06 May 2015 09:58:53 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Geert Uytterhoeven Cc: Linus Walleij , Alexandre Courbot , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan Wu , Richard Purdie , linux-leds@vger.kernel.org Subject: Re: [PATCH 09/27] leds: Allow compile test of GPIO consumers if !GPIOLIB References: <1430836404-15513-1-git-send-email-geert@linux-m68k.org> <1430843563-18615-1-git-send-email-geert@linux-m68k.org> <1430843563-18615-9-git-send-email-geert@linux-m68k.org> In-reply-to: <1430843563-18615-9-git-send-email-geert@linux-m68k.org> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNLMWRmVeSWpSXmKPExsVy+t/xK7r7TnqGGjz4YWzxd9IxdoujOycy WTy7tZfJ4tyrRywWU/4sZ7LYPP8Po8XlXXPYLLa+WcdosXvXU1YHTo/fvyYxeuycdZfd4861 PWwehw53MHrsmf+D1ePzJrkAtigum5TUnMyy1CJ9uwSujN/Pr7IVTOavuHzvFXMD4wyeLkZO DgkBE4mrr88zQdhiEhfurWfrYuTiEBJYyijx6NJsVgjnGaPEi/kLmUGqeAW0JI417GYDsVkE VCV2zT4EFmcTMJT4+eI12CRRgQiJP6f3sULUC0r8mHyPpYuRg0NEQFdizk8mkJnMApOYJLbP nsEEEhcWCJaY98MUYtcuRolZM1exg/RyCrhKXPv1AWwOs4C1xMpJ2xghbHmJzWveMk9gFJiF ZMUsJGWzkJQtYGRexSiaWppcUJyUnmuoV5yYW1yal66XnJ+7iRESBV92MC4+ZnWIUYCDUYmH N6DKM1SINbGsuDL3EKMEB7OSCO8Ud6AQb0piZVVqUX58UWlOavEhRmkOFiVx3rm73ocICaQn lqRmp6YWpBbBZJk4OKUaGL3W9z7cXBL4qeDjxdsMdrvOr734IJ2Xt/Qaj/hMCxPPIO3fL2yU spLDv7FVfuOfWhSx+Ly5Z38Ig1TXV6tlfQvXCDcYX3Q/FvjZ5w73+5urgj792GTVkp91/Iq1 VavNugjG5fdkPWVF73fcvZ6/OZZX7IJnm5+7/LLKJd8PftTSfpu0aOHxa0osxRmJhlrMRcWJ AAbwTWN+AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2130 Lines: 59 Hi Geert, Why don't you apply the same modification to all LED Kconfig entries with GPIOLIB dependency? On 05/05/2015 06:32 PM, Geert Uytterhoeven wrote: > The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is > not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer > functionality only, can still be compiled if GPIOLIB is not enabled. > > Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where > appropriate. > > Signed-off-by: Geert Uytterhoeven > Cc: Bryan Wu > Cc: Richard Purdie > Cc: linux-leds@vger.kernel.org > --- > drivers/leds/Kconfig | 2 +- > drivers/leds/trigger/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > index 966b9605f5f0660c..8161cddc3f8d597a 100644 > --- a/drivers/leds/Kconfig > +++ b/drivers/leds/Kconfig > @@ -395,7 +395,7 @@ config LEDS_INTEL_SS4200 > config LEDS_LT3593 > tristate "LED driver for LT3593 controllers" > depends on LEDS_CLASS > - depends on GPIOLIB > + depends on GPIOLIB || COMPILE_TEST > help > This option enables support for LEDs driven by a Linear Technology > LT3593 controller. This controller uses a special one-wire pulse > diff --git a/drivers/leds/trigger/Kconfig b/drivers/leds/trigger/Kconfig > index 49794b47b51c498d..5bda6a9b56bbd90b 100644 > --- a/drivers/leds/trigger/Kconfig > +++ b/drivers/leds/trigger/Kconfig > @@ -72,7 +72,7 @@ config LEDS_TRIGGER_CPU > config LEDS_TRIGGER_GPIO > tristate "LED GPIO Trigger" > depends on LEDS_TRIGGERS > - depends on GPIOLIB > + depends on GPIOLIB || COMPILE_TEST > help > This allows LEDs to be controlled by gpio events. It's good > when using gpios as switches and triggering the needed LEDs > -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/