Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752457AbbEFIGu (ORCPT ); Wed, 6 May 2015 04:06:50 -0400 Received: from www.linutronix.de ([62.245.132.108]:54570 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669AbbEFIGB (ORCPT ); Wed, 6 May 2015 04:06:01 -0400 Date: Wed, 6 May 2015 10:06:15 +0200 (CEST) From: Thomas Gleixner To: Baolin Wang cc: Arnd Bergmann , linux-kernel@vger.kernel.org, y2038 Mailman List Subject: Re: [PATCH v2 04/15] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure In-Reply-To: Message-ID: References: <1430381527-26349-1-git-send-email-baolin.wang@linaro.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2831 Lines: 65 On Wed, 6 May 2015, Baolin Wang wrote: > On 5 May 2015 at 21:31, Thomas Gleixner wrote: > > > On Thu, 30 Apr 2015, Baolin Wang wrote: > > > diff --git a/include/linux/posix-timers.h b/include/linux/posix-timers.h > > > index 907f3fd..35786c5 100644 > > > --- a/include/linux/posix-timers.h > > > +++ b/include/linux/posix-timers.h > > > @@ -98,9 +98,13 @@ struct k_itimer { > > > > > > struct k_clock { > > > int (*clock_getres) (const clockid_t which_clock, struct timespec > > *tp); > > > + int (*clock_getres64) (const clockid_t which_clock, struct > > timespec64 *tp); > > > int (*clock_set) (const clockid_t which_clock, > > > const struct timespec *tp); > > > + int (*clock_set64) (const clockid_t which_clock, > > > + const struct timespec64 *tp); > > > int (*clock_get) (const clockid_t which_clock, struct timespec * > > tp); > > > + int (*clock_get64) (const clockid_t which_clock, struct timespec64 > > *tp); > > > int (*clock_adj) (const clockid_t which_clock, struct timex *tx); > > > int (*timer_create) (struct k_itimer *timer); > > > int (*nsleep) (const clockid_t which_clock, int flags, > > > @@ -109,10 +113,15 @@ struct k_clock { > > > int (*timer_set) (struct k_itimer * timr, int flags, > > > struct itimerspec * new_setting, > > > struct itimerspec * old_setting); > > > + int (*timer_set64) (struct k_itimer *timr, int flags, > > > + struct itimerspec64 *new_setting, > > > + struct itimerspec64 *old_setting); > > > int (*timer_del) (struct k_itimer * timr); > > > #define TIMER_RETRY 1 > > > void (*timer_get) (struct k_itimer * timr, > > > struct itimerspec * cur_setting); > > > + void (*timer_get64) (struct k_itimer *timr, > > > + struct itimerspec64 *cur_setting); > > > > I asked you last time to provide a conversion for a single instance > > first and I gave you even step by step instructions. > > > > But you insist on resending the whole mess in one go. Try again. > > > > Thanks, > > > > tglx > > > > Hi Thomas, > > Thanks for your comments. I think i have followed your instructions > to convert the syscall functions in patch 5 and patch 6. > > And i have confusions about the "a single instance first", could you > explain that in detail? Thanks a lot. Single function, single syscall. Not a wholesale conversion of the world and some more. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/