Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752849AbbEFIbv (ORCPT ); Wed, 6 May 2015 04:31:51 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:35354 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750930AbbEFIbq (ORCPT ); Wed, 6 May 2015 04:31:46 -0400 MIME-Version: 1.0 In-Reply-To: <5549C9BD.8010903@samsung.com> References: <1430836404-15513-1-git-send-email-geert@linux-m68k.org> <1430843563-18615-1-git-send-email-geert@linux-m68k.org> <1430843563-18615-9-git-send-email-geert@linux-m68k.org> <5549C9BD.8010903@samsung.com> Date: Wed, 6 May 2015 10:31:46 +0200 X-Google-Sender-Auth: Wfqzd-tppRqBraivrPc-vKrrYIA Message-ID: Subject: Re: [PATCH 09/27] leds: Allow compile test of GPIO consumers if !GPIOLIB From: Geert Uytterhoeven To: Jacek Anaszewski Cc: Linus Walleij , Alexandre Courbot , Arnd Bergmann , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Bryan Wu , Richard Purdie , "linux-leds@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 38 Hi Jacek, On Wed, May 6, 2015 at 9:58 AM, Jacek Anaszewski wrote: > Why don't you apply the same modification to all LED Kconfig > entries with GPIOLIB dependency? LEDS_PCA9532_GPIO is a GPIO provider, not a consumer. There are no dummies for GPIO providers. LEDS_GPIO doesn't compile if !GPIOLIB, but I missed that it's just due to a missing dummy for devm_get_gpiod_from_child() and a missing include. Will fix. Thanks! > On 05/05/2015 06:32 PM, Geert Uytterhoeven wrote: >> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is >> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer >> functionality only, can still be compiled if GPIOLIB is not enabled. >> >> Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where >> appropriate. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/