Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752770AbbEFIzs (ORCPT ); Wed, 6 May 2015 04:55:48 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:35155 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783AbbEFIzp (ORCPT ); Wed, 6 May 2015 04:55:45 -0400 Message-ID: <5549D709.2050509@linaro.org> Date: Wed, 06 May 2015 16:55:37 +0800 From: zhangfei User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Stephen Boyd , Mike Turquette CC: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 07/19] clk: hix5hd2: Silence sparse warnings References: <1430897996-11597-1-git-send-email-sboyd@codeaurora.org> <1430897996-11597-8-git-send-email-sboyd@codeaurora.org> In-Reply-To: <1430897996-11597-8-git-send-email-sboyd@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1349 Lines: 38 On 05/06/2015 03:39 PM, Stephen Boyd wrote: > drivers/clk/hisilicon/clk-hix5hd2.c:255:13: warning: symbol 'hix5hd2_clk_register_complex' was not declared. Should it be static? > > Cc: Zhangfei Gao > Signed-off-by: Stephen Boyd Acked-by: Zhangfei Gao Thanks > --- > drivers/clk/hisilicon/clk-hix5hd2.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/hisilicon/clk-hix5hd2.c b/drivers/clk/hisilicon/clk-hix5hd2.c > index f1d239435826..78bd95b6fc7b 100644 > --- a/drivers/clk/hisilicon/clk-hix5hd2.c > +++ b/drivers/clk/hisilicon/clk-hix5hd2.c > @@ -252,8 +252,9 @@ static struct clk_ops clk_complex_ops = { > .disable = clk_complex_disable, > }; > > -void __init hix5hd2_clk_register_complex(struct hix5hd2_complex_clock *clks, > - int nums, struct hisi_clock_data *data) > +static void __init > +hix5hd2_clk_register_complex(struct hix5hd2_complex_clock *clks, int nums, > + struct hisi_clock_data *data) > { > void __iomem *base = data->base; > int i; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/