Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752184AbbEFJX3 (ORCPT ); Wed, 6 May 2015 05:23:29 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:35764 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751835AbbEFJXY (ORCPT ); Wed, 6 May 2015 05:23:24 -0400 Message-ID: <5549DD88.1010803@collabora.co.uk> Date: Wed, 06 May 2015 11:23:20 +0200 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Stephen Boyd , Mike Turquette CC: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 03/19] clk: max-gen: Silence sparse warnings References: <1430897996-11597-1-git-send-email-sboyd@codeaurora.org> <1430897996-11597-4-git-send-email-sboyd@codeaurora.org> In-Reply-To: <1430897996-11597-4-git-send-email-sboyd@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1303 Lines: 39 Hello Stephen, On 05/06/2015 09:39 AM, Stephen Boyd wrote: > drivers/clk/clk-max-gen.c:82:16: warning: symbol 'max_gen_clk_ops' was not declared. Should it be static? > drivers/clk/clk-max-gen.c:109:5: warning: symbol 'max_gen_clk_probe' was not declared. Should it be static? > drivers/clk/clk-max-gen.c:183:5: warning: symbol 'max_gen_clk_remove' was not declared. Should it be static? > > Cc: Javier Martinez Canillas > Signed-off-by: Stephen Boyd > --- > drivers/clk/clk-max-gen.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/clk-max-gen.c b/drivers/clk/clk-max-gen.c > index 6505049d50f1..35af9cb6da4f 100644 > --- a/drivers/clk/clk-max-gen.c > +++ b/drivers/clk/clk-max-gen.c > @@ -31,6 +31,8 @@ > #include > #include > > +#include "clk-max-gen.h" > + > struct max_gen_clk { > struct regmap *regmap; > u32 mask; > Looks good to me. Acked-by: Javier Martinez Canillas Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/