Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbbEFKX5 (ORCPT ); Wed, 6 May 2015 06:23:57 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:35122 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940AbbEFKXx (ORCPT ); Wed, 6 May 2015 06:23:53 -0400 Message-ID: <5549EBB5.8040806@gmail.com> Date: Wed, 06 May 2015 12:23:49 +0200 From: Jens Kuske User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Maxime Ripard CC: =?windows-1252?Q?Emilio_L=F3pez?= , Mike Turquette , Linus Walleij , Vinod Koul , Rob Herring , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 1/6] ARM: sunxi: Introduce Allwinner H3 support References: <1430904693-1404-1-git-send-email-jenskuske@gmail.com> <1430904693-1404-2-git-send-email-jenskuske@gmail.com> <20150506100446.GA11057@lukather> In-Reply-To: <20150506100446.GA11057@lukather> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2762 Lines: 78 On 06/05/15 12:04, Maxime Ripard wrote: > Hi, > > On Wed, May 06, 2015 at 11:31:28AM +0200, Jens Kuske wrote: >> The Allwinner H3 is a quad-core Cortex-A7-based SoC. It is very similar >> to other sun8i family SoCs like the A23. >> >> Signed-off-by: Jens Kuske >> --- >> Documentation/devicetree/bindings/arm/sunxi.txt | 1 + >> arch/arm/mach-sunxi/Kconfig | 2 +- >> arch/arm/mach-sunxi/sunxi.c | 3 ++- >> 3 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt b/Documentation/devicetree/bindings/arm/sunxi.txt >> index 42941fd..3cb4b94 100644 >> --- a/Documentation/devicetree/bindings/arm/sunxi.txt >> +++ b/Documentation/devicetree/bindings/arm/sunxi.txt >> @@ -9,4 +9,5 @@ using one of the following compatible strings: >> allwinner,sun6i-a31 >> allwinner,sun7i-a20 >> allwinner,sun8i-a23 >> + allwinner,sun8i-h3 >> allwinner,sun9i-a80 >> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig >> index 81502b9..47ac5b4 100644 >> --- a/arch/arm/mach-sunxi/Kconfig >> +++ b/arch/arm/mach-sunxi/Kconfig >> @@ -35,7 +35,7 @@ config MACH_SUN7I >> select SUN5I_HSTIMER >> >> config MACH_SUN8I >> - bool "Allwinner A23 (sun8i) SoCs support" >> + bool "Allwinner A23 / H3 (sun8i) SoCs support" > > I'd prefer that we have something similar to sun9i, just mentionning > the family here, instead of an ever-growing list of SoCs. > > This used to be easy to maintain, with the new naming scheme, we > already have at least 4 SoCs part of sun8i. According to Allwinners new naming scheme A20/A31/A31s are also part of sun8i (sun8iw[1,2]), but I think we can agree to use sun8i for the new SoCs, starting from A23. > >> default ARCH_SUNXI >> select ARM_GIC >> select MFD_SUN6I_PRCM >> diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c >> index 1bc811a..bc63748 100644 >> --- a/arch/arm/mach-sunxi/sunxi.c >> +++ b/arch/arm/mach-sunxi/sunxi.c >> @@ -67,10 +67,11 @@ MACHINE_END >> >> static const char * const sun8i_board_dt_compat[] = { >> "allwinner,sun8i-a23", >> + "allwinner,sun8i-h3", >> NULL, >> }; >> >> -DT_MACHINE_START(SUN8I_DT, "Allwinner sun8i (A23) Family") >> +DT_MACHINE_START(SUN8I_DT, "Allwinner sun8i (A23/H3) Family") > > Same comment here. > > Could you also update Documentation/arm/sunxi/README with these infos > (and ideally, updating it with the new SoCs we've heard about) ? > Will do. Jens -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/