Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752083AbbEFKYV (ORCPT ); Wed, 6 May 2015 06:24:21 -0400 Received: from mga03.intel.com ([134.134.136.65]:13351 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbbEFKYR (ORCPT ); Wed, 6 May 2015 06:24:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,379,1427785200"; d="scan'208";a="490015902" From: Andy Shevchenko To: linux-kernel@vger.kernel.org, Stephen Boyd , Mike Turquette , Lee Jones , Bryan Huntsman , Lorenzo Pieralisi , Ralf Baechle , Sylwester Nawrocki , Russell King - ARM Linux Cc: Andy Shevchenko Subject: [PATCH v4 0/1] clkdev: prevent potential memory leak when used in modules Date: Wed, 6 May 2015 13:24:11 +0300 Message-Id: <1430907852-160833-1-git-send-email-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2525 Lines: 59 Since clk_register_clkdev() is exported for modules the caller should get a pointer to the allocated resources. Otherwise the memory leak is guaranteed on the ->remove() stage. The patch changes the prototype of the clk_register_clkdev() to return a pointer to the allocated resources. The caller should take care of the returned variable and free allocated resources when needed. Together with the main change the users are updated too. The current change doesn't fix any present memory leak, thus developers and maintainers should take care of it if needed. The patch has been tested on x86 (*), thus requires to be tested on touched architectures. (*) On x86 there will be a user, more details at http://www.spinics.net/lists/kernel/msg1958587.html. Changelog v4: - rebase on recent linux-next - add Ack from Sylwester Nawrocki Changelog v3: - fix compiler warnings drivers/clk/samsung/clk-pll.c:1304:3: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long int' [-Wformat=] drivers/clk/samsung/clk-s3c2410-dclk.c:323:3: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=] drivers/clk/samsung/clk-s3c2410-dclk.c:243:6: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] Changelog v2: - update inplace documentation to mention clkdev_drop() that should be used to free the resources - mention in cover letter that we have tested it on x86 - append Mika's Reviewed-by tag - add Russel to the Cc list - rebase on top of 4.0-rc1 Andy Shevchenko (1): clkdev: change prototype of clk_register_clkdev() arch/arm/mach-vexpress/spc.c | 5 ++++- arch/mips/ath79/clock.c | 6 +++--- drivers/clk/clk-bcm2835.c | 12 +++++++----- drivers/clk/clk-max-gen.c | 9 ++++----- drivers/clk/clk-xgene.c | 6 +++--- drivers/clk/clkdev.c | 15 ++++++++++----- drivers/clk/samsung/clk-pll.c | 15 +++++++++------ drivers/clk/samsung/clk-s3c2410-dclk.c | 22 +++++++++++---------- drivers/clk/samsung/clk.c | 35 +++++++++++++++++++--------------- include/linux/clkdev.h | 2 +- 10 files changed, 73 insertions(+), 54 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/