Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752241AbbEFMUG (ORCPT ); Wed, 6 May 2015 08:20:06 -0400 Received: from down.free-electrons.com ([37.187.137.238]:45089 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751328AbbEFMUD (ORCPT ); Wed, 6 May 2015 08:20:03 -0400 Date: Wed, 6 May 2015 14:19:41 +0200 From: Maxime Ripard To: Jens Kuske Cc: Emilio =?iso-8859-1?Q?L=F3pez?= , Mike Turquette , Linus Walleij , Vinod Koul , Rob Herring , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Message-ID: <20150506121941.GD11057@lukather> References: <1430904693-1404-1-git-send-email-jenskuske@gmail.com> <1430904693-1404-6-git-send-email-jenskuske@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VMt1DrMGOVs3KQwf" Content-Disposition: inline In-Reply-To: <1430904693-1404-6-git-send-email-jenskuske@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 17139 Lines: 558 --VMt1DrMGOVs3KQwf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 06, 2015 at 11:31:32AM +0200, Jens Kuske wrote: > The Allwinner H3 is a home entertainment system oriented SoC with > four Cortex-A7 cores and a Mali-400MP2 GPU. >=20 > Signed-off-by: Jens Kuske > --- > arch/arm/boot/dts/sun8i-h3.dtsi | 468 ++++++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 468 insertions(+) > create mode 100644 arch/arm/boot/dts/sun8i-h3.dtsi >=20 > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3= =2Edtsi > new file mode 100644 > index 0000000..53aab95 > --- /dev/null > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > @@ -0,0 +1,468 @@ > +/* > + * Copyright (C) 2015 Jens Kuske > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This file is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This file is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public > + * License along with this file; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, > + * MA 02110-1301 USA Could you remove that last paragraph? It generates a checkpatch warning. > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +#include "skeleton.dtsi" > + > +#include > +#include > + > +/ { > + interrupt-parent =3D <&gic>; > + > + cpus { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + cpu@0 { > + compatible =3D "arm,cortex-a7"; > + device_type =3D "cpu"; > + reg =3D <0>; > + }; > + > + cpu@1 { > + compatible =3D "arm,cortex-a7"; > + device_type =3D "cpu"; > + reg =3D <1>; > + }; > + > + cpu@2 { > + compatible =3D "arm,cortex-a7"; > + device_type =3D "cpu"; > + reg =3D <2>; > + }; > + > + cpu@3 { > + compatible =3D "arm,cortex-a7"; > + device_type =3D "cpu"; > + reg =3D <3>; > + }; > + }; > + > + memory { > + reg =3D <0x40000000 0x80000000>; > + }; > + > + clocks { > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + ranges; > + > + osc24M: osc24M_clk { > + #clock-cells =3D <0>; > + compatible =3D "fixed-clock"; > + clock-frequency =3D <24000000>; > + clock-output-names =3D "osc24M"; > + }; > + > + osc32k: osc32k_clk { > + #clock-cells =3D <0>; > + compatible =3D "fixed-clock"; > + clock-frequency =3D <32768>; > + clock-output-names =3D "osc32k"; > + }; > + > + pll1: clk@01c20000 { > + #clock-cells =3D <0>; > + compatible =3D "allwinner,sun8i-a23-pll1-clk"; > + reg =3D <0x01c20000 0x4>; > + clocks =3D <&osc24M>; > + clock-output-names =3D "pll1"; > + }; > + > + pll6: clk@01c20028 { > + #clock-cells =3D <1>; > + compatible =3D "allwinner,sun8i-h3-pll6-clk"; > + reg =3D <0x01c20028 0x4>; > + clocks =3D <&osc24M>; > + clock-output-names =3D "pll6", "pll6x2", "pll6d2"; > + }; > + > + pll8: clk@01c20044 { > + #clock-cells =3D <0>; > + compatible =3D "allwinner,sun8i-h3-pll8-clk"; > + reg =3D <0x01c20044 0x4>; > + clocks =3D <&osc24M>; > + clock-output-names =3D "pll8"; > + }; > + > + cpu: cpu_clk@01c20050 { > + #clock-cells =3D <0>; > + compatible =3D "allwinner,sun4i-a10-cpu-clk"; > + reg =3D <0x01c20050 0x4>; > + clocks =3D <&osc32k>, <&osc24M>, <&pll1>, <&pll1>; > + clock-output-names =3D "cpu"; > + }; > + > + axi: axi_clk@01c20050 { > + #clock-cells =3D <0>; > + compatible =3D "allwinner,sun4i-a10-axi-clk"; > + reg =3D <0x01c20050 0x4>; > + clocks =3D <&cpu>; > + clock-output-names =3D "axi"; > + }; > + > + ahb1: ahb1_clk@01c20054 { > + #clock-cells =3D <0>; > + compatible =3D "allwinner,sun6i-a31-ahb1-clk"; > + reg =3D <0x01c20054 0x4>; > + clocks =3D <&osc32k>, <&osc24M>, <&axi>, <&pll6 0>; > + clock-output-names =3D "ahb1"; > + }; > + > + ahb2: ahb2_clk@01c2005c { > + #clock-cells =3D <0>; > + compatible =3D "allwinner,sun8i-h3-ahb2-clk"; > + reg =3D <0x01c2005c 0x4>; > + clocks =3D <&ahb1>, <&pll6 2>; > + clock-output-names =3D "ahb2"; > + }; > + > + apb1: apb1_clk@01c20054 { > + #clock-cells =3D <0>; > + compatible =3D "allwinner,sun4i-a10-apb0-clk"; > + reg =3D <0x01c20054 0x4>; > + clocks =3D <&ahb1>; > + clock-output-names =3D "apb1"; > + }; > + > + apb2: apb2_clk@01c20058 { > + #clock-cells =3D <0>; > + compatible =3D "allwinner,sun4i-a10-apb1-clk"; > + reg =3D <0x01c20058 0x4>; > + clocks =3D <&osc32k>, <&osc24M>, <&pll6 0>, <&pll6 0>; > + clock-output-names =3D "apb2"; > + }; > + > + ahb1_gates: ahb1_gates_clk@01c20060 { > + #clock-cells =3D <1>; > + compatible =3D "allwinner,sun8i-h3-ahb1-gates-clk"; > + reg =3D <0x01c20060 0x14>; > + clocks =3D <&ahb1>; > + clock-output-names =3D "ahb1_ce", "ahb1_dma", "ahb1_mmc0", > + "ahb1_mmc1", "ahb1_mmc2", "ahb1_nand", > + "ahb1_sdram", "ahb1_ts", "ahb1_hstimer", > + "ahb1_spi0", "ahb1_spi1", "ahb1_otg", > + "ahb1_otg_ehci0", "ahb1_ehic1", > + "ahb1_ehic2", "ahb1_ehic3", > + "ahb1_otg_ohci0", "ahb1_ve", > + "ahb1_lcd0", "ahb1_lcd1", "ahb1_deint", > + "ahb1_csi", "ahb1_tve", "ahb1_hdmi", > + "ahb1_de", "ahb1_gpu", "ahb1_msgbox", > + "ahb1_spinlock", "ahb1_ephy", "ahb1_dbg"; > + }; > + > + ahb2_gates: ahb2_gates_clk@01c20060 { > + #clock-cells =3D <1>; > + compatible =3D "allwinner,sun8i-h3-ahb2-gates-clk"; > + reg =3D <0x01c20060 0x4>; > + clocks =3D <&ahb2>; > + clock-output-names =3D "ahb2_gmac", "ahb2_ohic1", > + "ahb2_ohic2", "ahb2_ohic3"; > + }; > + > + apb1_gates: clk@01c20068 { > + #clock-cells =3D <1>; > + compatible =3D "allwinner,sun8i-h3-apb1-gates-clk"; > + reg =3D <0x01c20068 0x4>; > + clocks =3D <&apb1>; > + clock-output-names =3D "apb1_codec", "apb1_spdif", > + "apb1_pio", "apb1_ths", "apb1_i2s0", > + "apb1_i2s1", "apb1_i2s2"; > + }; > + > + apb2_gates: clk@01c2006c { > + #clock-cells =3D <1>; > + compatible =3D "allwinner,sun8i-h3-apb2-gates-clk"; > + reg =3D <0x01c2006c 0x4>; > + clocks =3D <&apb2>; > + clock-output-names =3D "apb2_i2c0", "apb2_i2c1", > + "apb2_i2c2", "apb2_uart0", > + "apb2_uart1", "apb2_uart2", > + "apb2_uart3", "apb2_sim"; I'd prefer if the clocks on a new line were right-aligned (like you did for the mmc clocks just below). > + }; > + > + mmc0_clk: clk@01c20088 { > + #clock-cells =3D <1>; > + compatible =3D "allwinner,sun4i-a10-mmc-clk"; > + reg =3D <0x01c20088 0x4>; > + clocks =3D <&osc24M>, <&pll6 0>, <&pll8>; > + clock-output-names =3D "mmc0", > + "mmc0_output", > + "mmc0_sample"; > + }; > + > + mmc1_clk: clk@01c2008c { > + #clock-cells =3D <1>; > + compatible =3D "allwinner,sun4i-a10-mmc-clk"; > + reg =3D <0x01c2008c 0x4>; > + clocks =3D <&osc24M>, <&pll6 0>, <&pll8>; > + clock-output-names =3D "mmc1", > + "mmc1_output", > + "mmc1_sample"; > + }; > + > + mmc2_clk: clk@01c20090 { > + #clock-cells =3D <1>; > + compatible =3D "allwinner,sun4i-a10-mmc-clk"; > + reg =3D <0x01c20090 0x4>; > + clocks =3D <&osc24M>, <&pll6 0>, <&pll8>; > + clock-output-names =3D "mmc2", > + "mmc2_output", > + "mmc2_sample"; > + }; > + }; > + > + soc@01c00000 { > + compatible =3D "simple-bus"; > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + ranges; > + > + dma: dma-controller@01c02000 { > + compatible =3D "allwinner,sun8i-h3-dma"; > + reg =3D <0x01c02000 0x1000>; > + interrupts =3D ; > + clocks =3D <&ahb1_gates 6>; > + resets =3D <&ahb12_rst 6>; > + #dma-cells =3D <1>; > + }; > + > + mmc0: mmc@01c0f000 { > + compatible =3D "allwinner,sun5i-a13-mmc"; > + reg =3D <0x01c0f000 0x1000>; > + clocks =3D <&ahb1_gates 8>, > + <&mmc0_clk 0>, > + <&mmc0_clk 1>, > + <&mmc0_clk 2>; > + clock-names =3D "ahb", > + "mmc", > + "output", > + "sample"; > + resets =3D <&ahb12_rst 8>; > + reset-names =3D "ahb"; > + interrupts =3D ; > + status =3D "disabled"; > + }; > + > + mmc1: mmc@01c10000 { > + compatible =3D "allwinner,sun5i-a13-mmc"; > + reg =3D <0x01c10000 0x1000>; > + clocks =3D <&ahb1_gates 9>, > + <&mmc1_clk 0>, > + <&mmc1_clk 1>, > + <&mmc1_clk 2>; > + clock-names =3D "ahb", > + "mmc", > + "output", > + "sample"; > + resets =3D <&ahb12_rst 9>; > + reset-names =3D "ahb"; > + interrupts =3D ; > + status =3D "disabled"; > + }; > + > + mmc2: mmc@01c11000 { > + compatible =3D "allwinner,sun5i-a13-mmc"; > + reg =3D <0x01c11000 0x1000>; > + clocks =3D <&ahb1_gates 10>, > + <&mmc2_clk 0>, > + <&mmc2_clk 1>, > + <&mmc2_clk 2>; > + clock-names =3D "ahb", > + "mmc", > + "output", > + "sample"; > + resets =3D <&ahb12_rst 10>; > + reset-names =3D "ahb"; > + interrupts =3D ; > + status =3D "disabled"; > + }; > + > + pio: pinctrl@01c20800 { > + compatible =3D "allwinner,sun8i-h3-pinctrl"; > + reg =3D <0x01c20800 0x400>; > + interrupts =3D , > + ; > + clocks =3D <&apb1_gates 5>; > + gpio-controller; > + interrupt-controller; > + #interrupt-cells =3D <2>; > + #size-cells =3D <0>; > + #gpio-cells =3D <3>; > + > + uart0_pins_a: uart0@0 { > + allwinner,pins =3D "PA4", "PA5"; > + allwinner,function =3D "uart0"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > + > + mmc0_pins_a: mmc0@0 { > + allwinner,pins =3D "PF0","PF1","PF2","PF3","PF4","PF5"; Could you have spaces between the commas, and wrap the line at 80 chars? > + allwinner,function =3D "mmc0"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > + > + mmc0_cd_pin: mmc0_cd_pin@0 { > + allwinner,pins =3D "PF6"; > + allwinner,function =3D "gpio_in"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > + > + mmc1_pins_a: mmc1@0 { > + allwinner,pins =3D "PG0","PG1","PG2","PG3","PG4","PG5"; > + allwinner,function =3D "mmc1"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > + }; > + > + ahb12_rst: reset@01c202c0 { > + #reset-cells =3D <1>; > + compatible =3D "allwinner,sun6i-a31-clock-reset"; > + reg =3D <0x01c202c0 0xc>; > + }; This reset controller also resets the timers, it should be initialised much earlier. What about having an allwinner,sun8i-h3-bus-reset, and adding it to the list of compatibles to initialise earlier in drivers/reset/reset-sunxi.c? Of course, it would cover the other reset controllers that you have below. > + apb1_rst: reset@01c202d0 { > + #reset-cells =3D <1>; > + compatible =3D "allwinner,sun6i-a31-clock-reset"; > + reg =3D <0x01c202d0 0x4>; > + }; > + > + apb2_rst: reset@01c202d8 { > + #reset-cells =3D <1>; > + compatible =3D "allwinner,sun6i-a31-clock-reset"; > + reg =3D <0x01c202d8 0x4>; > + }; > + > + timer@01c20c00 { > + compatible =3D "allwinner,sun4i-a10-timer"; > + reg =3D <0x01c20c00 0xa0>; > + interrupts =3D , > + ; > + clocks =3D <&osc24M>; > + }; > + > + wdt0: watchdog@01c20ca0 { > + compatible =3D "allwinner,sun6i-a31-wdt"; > + reg =3D <0x01c20ca0 0x20>; > + interrupts =3D ; > + }; > + > + uart0: serial@01c28000 { > + compatible =3D "snps,dw-apb-uart"; > + reg =3D <0x01c28000 0x400>; > + interrupts =3D ; > + reg-shift =3D <2>; > + reg-io-width =3D <4>; > + clocks =3D <&apb2_gates 16>; > + resets =3D <&apb2_rst 16>; > + dmas =3D <&dma 6>, <&dma 6>; > + dma-names =3D "rx", "tx"; > + status =3D "disabled"; > + }; > + > + uart1: serial@01c28400 { > + compatible =3D "snps,dw-apb-uart"; > + reg =3D <0x01c28400 0x400>; > + interrupts =3D ; > + reg-shift =3D <2>; > + reg-io-width =3D <4>; > + clocks =3D <&apb2_gates 17>; > + resets =3D <&apb2_rst 17>; > + dmas =3D <&dma 7>, <&dma 7>; > + dma-names =3D "rx", "tx"; > + status =3D "disabled"; > + }; > + > + uart2: serial@01c28800 { > + compatible =3D "snps,dw-apb-uart"; > + reg =3D <0x01c28800 0x400>; > + interrupts =3D ; > + reg-shift =3D <2>; > + reg-io-width =3D <4>; > + clocks =3D <&apb2_gates 18>; > + resets =3D <&apb2_rst 18>; > + dmas =3D <&dma 8>, <&dma 8>; > + dma-names =3D "rx", "tx"; > + status =3D "disabled"; > + }; > + > + uart3: serial@01c28c00 { > + compatible =3D "snps,dw-apb-uart"; > + reg =3D <0x01c28c00 0x400>; > + interrupts =3D ; > + reg-shift =3D <2>; > + reg-io-width =3D <4>; > + clocks =3D <&apb2_gates 19>; > + resets =3D <&apb2_rst 19>; > + dmas =3D <&dma 9>, <&dma 9>; > + dma-names =3D "rx", "tx"; > + status =3D "disabled"; > + }; > + > + gic: interrupt-controller@01c81000 { > + compatible =3D "arm,cortex-a7-gic", "arm,cortex-a15-gic"; > + reg =3D <0x01c81000 0x1000>, > + <0x01c82000 0x1000>, > + <0x01c84000 0x2000>, > + <0x01c86000 0x2000>; > + interrupt-controller; > + #interrupt-cells =3D <3>; > + interrupts =3D ; > + }; > + > + rtc: rtc@01f00000 { > + compatible =3D "allwinner,sun6i-a31-rtc"; > + reg =3D <0x01f00000 0x54>; > + interrupts =3D , > + ; > + }; > + }; > +}; > --=20 > 2.3.7 >=20 Have you tested the architected timers? Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --VMt1DrMGOVs3KQwf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVSgbdAAoJEBx+YmzsjxAgaywQAKIH6UUqk7PG2ywO9MtHVX7w mQ6nUaw8UURrA9mYngVKKibSpUQTVtt8PdZttarEDPlldMyHPuCn5Zx6oXhs8z+j wFkOVOY4A2/ByQTurs2NE44u9tpCTSXKNhYkgHNzX+m04TAZRb1X8IaCSV8f5LLc gKljvVjeeP9kG5GBK/irFC1qRCiKQDycHsdp8MRg4mvsy3hNwKB6JzqupR8wfXn+ zkuuWYo8y3YqEdqbqpQAzeMnHtVeKo8GA3UsHBti9phOi+/HFNyZ7tZ+vanZlowv P6QC5Nck19h+K3ERhVCFepD/fyg5N/9n8heZ2unc5zHEz4dS8X9manihs6UzzMt6 GOUh16gSgKsMzwL1FJdrPvQeyd7ze0zR3Xr0UBaN1+rRbXlBLlvPlESNmGZ2GuP6 4hRiFCFemyGxzRMU8JKr01bZEUlYz0A4nJC45MC9+lfYgh69n3v0fdxUiUYnKolq XqPuAYmpGeQHyXL63wCvoQmMMhIMXz2Eva0dOxhTuxKa36PCFU9RxuqJ0zZ1eV+g o7cxY3uZePHCDfKCcFiWm3wb3VMBXjRI3URENv2P/RJjDQ1l+ewMc8JvJ0Zgga9t OKlsh1qg4E4H3gptDeIQFgW8z79pJePaCM0Ez226bS0s215n5swRFfSn5VyI++K8 cxFkO6C6D5r/Zu+AJPbY =re2H -----END PGP SIGNATURE----- --VMt1DrMGOVs3KQwf-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/