Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751583AbbEFMZK (ORCPT ); Wed, 6 May 2015 08:25:10 -0400 Received: from down.free-electrons.com ([37.187.137.238]:45297 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751135AbbEFMZE (ORCPT ); Wed, 6 May 2015 08:25:04 -0400 Date: Wed, 6 May 2015 14:23:02 +0200 From: Maxime Ripard To: Jens Kuske Cc: Emilio =?iso-8859-1?Q?L=F3pez?= , Mike Turquette , Linus Walleij , Vinod Koul , Rob Herring , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 3/6] pinctrl: sunxi: Add H3 PIO controller support Message-ID: <20150506122302.GF11057@lukather> References: <1430904693-1404-1-git-send-email-jenskuske@gmail.com> <1430904693-1404-4-git-send-email-jenskuske@gmail.com> <20150506101137.GB11057@lukather> <5549EE36.4060603@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IvGM3kKqwtniy32b" Content-Disposition: inline In-Reply-To: <5549EE36.4060603@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2181 Lines: 59 --IvGM3kKqwtniy32b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 06, 2015 at 12:34:30PM +0200, Jens Kuske wrote: > >> + SUNXI_PIN(SUNXI_PINCTRL_PIN(A, 6), > >> + SUNXI_FUNCTION(0x0, "gpio_in"), > >> + SUNXI_FUNCTION(0x1, "gpio_out"), > >> + SUNXI_FUNCTION(0x2, "scr"), /* PWREN */ > >=20 > > The datasheet uses "SIM" for this, why have you changed the name here? >=20 > Thought I had changed that back. I first used scr because the > responsible module is called scr everywhere else (clocks, memory map). > Looks like I messed it up now and called the clocks "sim" instead... >=20 > I think I should also redo the dtsi and use scr for the clock again, to > stay compatible with how it was called in Manual and earlier sunxi SoCs. It seems reasonable :) Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --IvGM3kKqwtniy32b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVSgemAAoJEBx+YmzsjxAgRa4P/2uR6JnwRd8UgBUHRYcnXBjO 3tjpjtaaHn8K/Jew1ryrsJQVDb6nFhg7I2FMUtIVHs1HXSjzFl8XmaFOnJv6M4EI noEYmxMENdyzyu/XAsbOPeWoNpByuzCdUzWmQwaiDVHCN7cS10LJdDiJJhO/lIKl 7WJ4Qs3HgDRIIbJGoxR/WFEReETQFRBBYFrQj732s9iN/ZwiPBZdYBLboib+hhnL 8IwZA89X+tUfjiHQoqX7uMiS14eeEiRTfVDorJt8zagopmabDtwJEJF2PTPXicKh rtHIxYqt5YFe+FNuj/6MWMx3eLMdUkcuXgk0g/QxG1N0lzS+xYwnxm1jdIbfX0zT qF/h3kEakjOWgJjUa0eTJa7f6Qjfm7ECrhifpNdtbHz7OrjP3N3c1Ths1sOMIBDN VNua1g1xEITOh8OtkZmmpLg7ve45u/3Cy/KnKlSbXwX+pvm2qNT5VKUCSUnH9ngL gywSF57qVowwAN7Uq9CfIQI9xR3guJXwUIXgKlOF8LIEj1cK7BEiQDgSb07ybNMB 5LysDamfEl2/MwUJ3SOxuZcvvliOPIg544kFVWUh2W37LKGAcUFav3TuTQCa5+2t NSU4uHmyvCvkc0ttYcVQPHtTr8IrHvZlgLtmCRp2RZ7R2BQvgwOkwCGyDbL9ygQI 4PVldu3Y8gr+bWzax+wU =KUeH -----END PGP SIGNATURE----- --IvGM3kKqwtniy32b-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/