Date: Wed, 6 May 2015 13:51:28 +0100
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
        Mike Turquette <mturquette@linaro.org>, Lee Jones <lee@kernel.org>,
        Bryan Huntsman <bryanh@codeaurora.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: Re: [PATCH v4 1/1] clkdev: change prototype of clk_register_clkdev()
Message-ID: <20150506125128.GU2067@n2100.arm.linux.org.uk>
References: <1430907852-160833-1-git-send-email-andriy.shevchenko@linux.intel.com>
 <1430907852-160833-2-git-send-email-andriy.shevchenko@linux.intel.com>
 <20150506110956.GN2067@n2100.arm.linux.org.uk>
 <1430915649.28073.6.camel@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1430915649.28073.6.camel@linux.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1564
Lines: 37

On Wed, May 06, 2015 at 03:34:09PM +0300, Andy Shevchenko wrote:
> On Wed, 2015-05-06 at 12:09 +0100, Russell King - ARM Linux wrote:
> > On Wed, May 06, 2015 at 01:24:12PM +0300, Andy Shevchenko wrote:
> > > Since clk_register_clkdev() is exported for modules the caller should get a
> > > pointer to the allocated resources. Otherwise the memory leak is guaranteed on
> > > the ->remove() stage.
> > 
> > clk_register_clkdev() is there to assist mass clock registrations, which
> > typically happen in platform code.  It's there to simplify the "I need
> > to register this clock which I'm not going to release again".
> > 
> > I don't see any of these locations trying to unregister their clk from
> > clkdev, so I doubt this patch is needed.
> 
> We are doing the driver which will use this (as I mentioned in the cover
> letter).
> 
> > 
> > Where a module wants to remove its clk from clkdev, it should register
> > its clk with clkdev_create() and remove it with clkdev_drop().
> > 
> 
> You are talking about something in the wild? I can't find
> clkdev_create() neither in current clk.git nor in linux-next.git.

It'll be in linux-next RSN.

Search lakml for "Fix fallout from per-user struct clk patches"

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/