Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbbEFNQu (ORCPT ); Wed, 6 May 2015 09:16:50 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:48005 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078AbbEFNQp (ORCPT ); Wed, 6 May 2015 09:16:45 -0400 Date: Wed, 6 May 2015 09:16:22 -0400 From: Johannes Weiner To: Michal Hocko Cc: Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Greg Thelen , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] gfp: add __GFP_NOACCOUNT Message-ID: <20150506131622.GA4629@cmpxchg.org> References: <20150506115941.GH14550@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150506115941.GH14550@dhcp22.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1280 Lines: 30 On Wed, May 06, 2015 at 01:59:41PM +0200, Michal Hocko wrote: > On Tue 05-05-15 12:45:42, Vladimir Davydov wrote: > > Not all kmem allocations should be accounted to memcg. The following > > patch gives an example when accounting of a certain type of allocations > > to memcg can effectively result in a memory leak. > > > This patch adds the __GFP_NOACCOUNT flag which if passed to kmalloc > > and friends will force the allocation to go through the root > > cgroup. It will be used by the next patch. > > The name of the flag is way too generic. It is not clear that the > accounting is KMEMCG related. The memory controller is the (primary) component that accounts physical memory allocations in the kernel, so I don't see how this would be ambiguous in any way. > __GFP_NO_KMEMCG sounds better? I think that's much worse. I would prefer communicating the desired behavior directly instead of having to derive it from a subsystem name. (And KMEMCG should not even be a term, it's all just the memory controller, i.e. memcg.) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/