Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752587AbbEFNaj (ORCPT ); Wed, 6 May 2015 09:30:39 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:57005 "EHLO e28smtp06.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752546AbbEFNah (ORCPT ); Wed, 6 May 2015 09:30:37 -0400 Date: Wed, 6 May 2015 19:00:24 +0530 From: Srikar Dronamraju To: Oleg Nesterov Cc: Ananth N Mavinakayanahalli , Anton Arapov , David Long , Denys Vlasenko , "Frank Ch. Eigler" , Ingo Molnar , Jan Willeke , Jim Keniston , Mark Wielaard , Pratyush Anand , linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/10] uprobes: Send SIGILL if handle_trampoline() fails Message-ID: <20150506133024.GE4519@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20150504124835.GA22462@redhat.com> <20150504124858.GA22488@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20150504124858.GA22488@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15050613-0021-0000-0000-0000050B3E3B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 25 * Oleg Nesterov [2015-05-04 14:48:58]: > 1. It doesn't make sense to continue if handle_trampoline() fails, > change handle_swbp() to always return after this call. > > 2. Turn pr_warn() into uprobe_warn(), and change handle_trampoline() > to send SIGILL on failure. It is pointless to return to user mode > with the corrupted instruction_pointer() which we can't restore. I agree > > Signed-off-by: Oleg Nesterov > --- Acked-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/