Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752541AbbEFNac (ORCPT ); Wed, 6 May 2015 09:30:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35426 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbbEFNaa (ORCPT ); Wed, 6 May 2015 09:30:30 -0400 Message-ID: <554A1774.6080801@suse.cz> Date: Wed, 06 May 2015 15:30:28 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Andrey Skvortsov CC: maximilian attems , Ben Hutchings , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] builddeb: fix stripped module signatures if CONFIG_DEBUG_INFO and CONFIG_MODULE_SIG_ALL are set References: <1426494054-32138-1-git-send-email-andrej.skvortzov@gmail.com> <55365798.4090302@suse.cz> <20150422155700.GD32026@gluino> <20150504153724.GA26392@nest> In-Reply-To: <20150504153724.GA26392@nest> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1971 Lines: 46 On 2015-05-04 17:37, Andrey Skvortsov wrote: > On 22 Apr, maximilian attems wrote: >> On Tue, Apr 21, 2015 at 03:58:48PM +0200, Michal Marek wrote: >>> (added Max to Cc) >>> >>> On 2015-03-16 09:20, Andrey Skvortsov wrote: >>>> If CONFIG_MODULE_SIG_ALL is set, then user expects that all modules are >>>> automatically signed in the result package, as it's for rpm-pkg, binrpm-pkg, >>>> tar, tar-*. For deb-pkg this is correct only if CONFIG_DEBUG_INFO >>>> is NOT set. In that case deb-package contains signed modules. >>>> >>>> But if CONFIG_DEBUG_INFO is set, builddeb creates separate package with >>>> debug information. To do that, debug information from all modules >>>> is copied into separate files by objcopy. And loadable kernel modules are >>>> stripped afterwards. Stripping removes previously (during modules_install) >>>> added signatures from loadable kernel modules. Therefore final deb-package >>>> contains unsigned modules despite of set option CONFIG_MODULE_SIG_ALL. >>>> >>>> This patch resigns all stripped modules if CONFIG_MODULE_SIG_ALL is set >>>> to solve this problem. >>>> >>>> Signed-off-by: Andrey Skvortsov >>> >>> Max, Ben, are you fine with this patch? It looks OK to me, the >>> modules_sign target has been added for this very purpose. >>> >> >> Ben seems busy with the release, so jumping in. The patch looks >> perfect to me. >> >> Acked-by: maximilian attems >> > Maximilian, thanks for the review. > > Michal, are we waiting for Ben's acknowledge too? I applied the patch to kbuild.git#misc now, after fixing the whitespace. Andrey, please use tabs for indentation, especially when the surrounding code is already using this style. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/