Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbbEFOTB (ORCPT ); Wed, 6 May 2015 10:19:01 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:33745 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751909AbbEFOS7 (ORCPT ); Wed, 6 May 2015 10:18:59 -0400 Date: Wed, 6 May 2015 10:18:58 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Ramneek Mehresh cc: Kernel development list , Felipe Balbi , USB list , "gregkh@linuxfoundation.org" Subject: RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 24 On Wed, 6 May 2015, Ramneek Mehresh wrote: > > Also, I'm not going to let you add new fields into the ehci_driver_overrides > > structure. If you really need to override other routines, copy the approach > > used by ehci-tegra.c. > > > Understood...but I would appreciate if you could please explain the harm in doing so The fields in the override structure are meant for convenience. The extra_priv_size field is the most important one; the other two fields (reset and port_power) are present only because so many drivers need them. There's no reason to add an extra field for something that will be used in only one driver. You can do the override by hand, instead of wasting space in a whole bunch of other drivers. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/