Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752729AbbEFOZh (ORCPT ); Wed, 6 May 2015 10:25:37 -0400 Received: from mail-bl2on0145.outbound.protection.outlook.com ([65.55.169.145]:18144 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751878AbbEFOZc convert rfc822-to-8bit (ORCPT ); Wed, 6 May 2015 10:25:32 -0400 From: Ramneek Mehresh To: Alan Stern CC: Kernel development list , Felipe Balbi , USB list , "gregkh@linuxfoundation.org" Subject: RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver Thread-Topic: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver Thread-Index: AQHQh1uKl7mjiKlO10ShKrKkIr6ymp1txRAAgACnYmCAAJQFAIAAAQoQ Date: Wed, 6 May 2015 14:25:30 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: rowland.harvard.edu; dkim=none (message not signed) header.d=none; x-originating-ip: [192.88.166.1] x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB1582; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:SN1PR0301MB1582;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB1582; x-forefront-prvs: 0568F32D91 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(51704005)(377454003)(501624003)(24454002)(13464003)(19580405001)(110136002)(46102003)(74316001)(19580395003)(122556002)(40100003)(5001960100002)(99286002)(92566002)(62966003)(77156002)(54356999)(76176999)(50986999)(2950100001)(2900100001)(102836002)(106116001)(86362001)(2171001)(2656002)(87936001)(33656002)(76576001)(66066001)(189998001);DIR:OUT;SFP:1102;SCL:1;SRVR:SN1PR0301MB1582;H:SN1PR0301MB1583.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2015 14:25:30.1486 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1582 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1546 Lines: 38 > -----Original Message----- > From: Alan Stern [mailto:stern@rowland.harvard.edu] > Sent: Wednesday, May 06, 2015 7:49 PM > To: Mehresh Ramneek-B31383 > Cc: Kernel development list; Felipe Balbi; USB list; > gregkh@linuxfoundation.org > Subject: RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb > host driver > > On Wed, 6 May 2015, Ramneek Mehresh wrote: > > > > Also, I'm not going to let you add new fields into the > > > ehci_driver_overrides structure. If you really need to override > > > other routines, copy the approach used by ehci-tegra.c. > > > > > Understood...but I would appreciate if you could please explain the > > harm in doing so > > The fields in the override structure are meant for convenience. The > extra_priv_size field is the most important one; the other two fields (reset > and port_power) are present only because so many drivers need them. > > There's no reason to add an extra field for something that will be used in only > one driver. You can do the override by hand, instead of wasting space in a > whole bunch of other drivers. > Ok...i thought "overrides" structure is to enforce a field by a driver on generic structure... But now it appears that it's only for most popular fields only...i'll make changes in my driver only > Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/