Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752472AbbEFOrc (ORCPT ); Wed, 6 May 2015 10:47:32 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:33804 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752023AbbEFOra (ORCPT ); Wed, 6 May 2015 10:47:30 -0400 Date: Wed, 6 May 2015 10:47:29 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Ramneek Mehresh cc: Kernel development list , Felipe Balbi , USB list , "gregkh@linuxfoundation.org" Subject: RE: [PATCH 2/9][v3]usb:fsl:otg: Add support to add/remove usb host driver In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1240 Lines: 26 On Wed, 6 May 2015, Ramneek Mehresh wrote: > > The fields in the override structure are meant for convenience. The > > extra_priv_size field is the most important one; the other two fields (reset > > and port_power) are present only because so many drivers need them. > > > > There's no reason to add an extra field for something that will be used in only > > one driver. You can do the override by hand, instead of wasting space in a > > whole bunch of other drivers. > > > Ok...i thought "overrides" structure is to enforce a field by a driver on generic structure... Consider what would happen if that were true. Your driver would want to override three extra fields, so you would add them to the structure. Some other driver would want to override two others, so it would add them to the structure. Then some other driver would need to override more fields... Eventually the overrides structure would contain everything that is already present in struct ehci_hcd! Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/