Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752044AbbEFQUh (ORCPT ); Wed, 6 May 2015 12:20:37 -0400 Received: from mail.kernel.org ([198.145.29.136]:43217 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbbEFQUc (ORCPT ); Wed, 6 May 2015 12:20:32 -0400 Date: Wed, 6 May 2015 12:52:36 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: ananth@in.ibm.com, Peter Zijlstra , hemant@linux.vnet.ibm.com, Linux Kernel Mailing List , David Ahern , namhyung@kernel.org, Jiri Olsa , Ingo Molnar Subject: Re: [PATCH perf/core 6/8] perf-probe: Add --no-inlines option to avoid searching inline functions Message-ID: <20150506155236.GA7862@kernel.org> References: <20150506124638.4961.3172.stgit@localhost.localdomain> <20150506124651.4961.11.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150506124651.4961.11.stgit@localhost.localdomain> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 23 Em Wed, May 06, 2015 at 09:46:51PM +0900, Masami Hiramatsu escreveu: > Add --no-inlines(--inlines) option to avoid searching inline > functions. > Searching all functions which matches glob pattern can take a > long time and find a lot of inline functions. With this option > perf-probe searches target on the non-inlined functions. > > > ret = add_perf_probe_events(params.events, params.nevents, > params.max_probe_points, > - params.force_add); > + params.force_add, > + params.no_inlines); So, there is just one call to this function, and all the parameters come from the 'param' struct, why not just pass it? - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/