Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752100AbbEFQUv (ORCPT ); Wed, 6 May 2015 12:20:51 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:14683 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751962AbbEFQUg (ORCPT ); Wed, 6 May 2015 12:20:36 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 06 May 2015 09:18:38 -0700 Message-ID: <554A3F52.9090608@nvidia.com> Date: Wed, 6 May 2015 12:20:34 -0400 From: Rhyland Klein User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Thierry Reding , Jim Lin CC: Peter De Schrijver , Mike Turquette , Stephen Warren , Stephen Boyd , Alexandre Courbot , , , Subject: Re: [PATCH v4 02/20] clk: tegra: periph: add new periph clks and muxes for Tegra210 References: <1430757460-9478-1-git-send-email-rklein@nvidia.com> <1430757460-9478-3-git-send-email-rklein@nvidia.com> <5549F900.2050600@nvidia.com> <20150506141524.GE22098@ulmo.nvidia.com> In-Reply-To: <20150506141524.GE22098@ulmo.nvidia.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 47 On 5/6/2015 10:15 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Wed, May 06, 2015 at 07:20:32PM +0800, Jim Lin wrote: >> On 05/05/2015 12:37 AM, Rhyland Klein wrote: > [...] >>> diff --git a/drivers/clk/tegra/clk-tegra-periph.c b/drivers/clk/tegra/clk-tegra-periph.c > [...] >>> @@ -333,6 +497,11 @@ static u32 mux_clkm_48M_pllp_480M_idx[] = { >>> [0] = 0, [1] = 2, [2] = 4, [3] = 6, >>> }; >>> +static const char *mux_clkm_pllre_clk32_480M[] = { >>> + "clk_m", "pll_re_out", "clk_32k", "pll_u_480M" >>> +}; >>> +#define mux_clkm_pllre_clk32_480M_idx NULL >> Please help to replace above >> >> #define mux_clkm_pllre_clk32_480M_idx NULL >> >> with >> >> static u32 mux_clkm_pllre_clk32_480M_idx[] = { >> >> [0] = 0, [1] = 1, [2] = 2, [3] = 3, >> }; > > Isn't that the default already if you specify NULL as index table? It should be, so there shouldn't be a need to explicitly define this. -rhyland > > Thierry > > * Unknown Key > * 0x7F3EB3A1 > -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/