Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751976AbbEFRVK (ORCPT ); Wed, 6 May 2015 13:21:10 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:17466 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbbEFRVI (ORCPT ); Wed, 6 May 2015 13:21:08 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 06 May 2015 10:19:39 -0700 Message-ID: <554A4D82.80307@nvidia.com> Date: Wed, 6 May 2015 13:21:06 -0400 From: Rhyland Klein User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Thierry Reding , Peter De Schrijver CC: Mike Turquette , Stephen Warren , Stephen Boyd , Alexandre Courbot , , , Subject: Re: [PATCH v4 19/20] clk: tegra210: add support for Tegra210 clocks References: <1430757460-9478-1-git-send-email-rklein@nvidia.com> <1430757460-9478-20-git-send-email-rklein@nvidia.com> <20150506145113.GH22098@ulmo.nvidia.com> In-Reply-To: <20150506145113.GH22098@ulmo.nvidia.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1032 Lines: 37 On 5/6/2015 10:51 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, May 04, 2015 at 12:37:39PM -0400, Rhyland Klein wrote: > [...] >> diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c > [...] >> +static struct div_nmp plld_nmp = { >> + .divm_shift = 0, >> + .divm_width = 8, >> + .divn_shift = 11, >> + .divn_width = 8, >> + .divp_shift = 20, >> + .divp_width = 3, >> +}; > > I think we need to add the SDM shift and width fields here: > > .sdm_shift = 0, > .sdm_width = 16, > > Otherwise pll_d can't take advantage of the fractional divider. > Actually, sdm_shift/width aren't used. I originally added them to handle SDM data, but eventually I switched to using a reg/mask combo. So this isn't needed. -rhyland -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/