Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752269AbbEFR2x (ORCPT ); Wed, 6 May 2015 13:28:53 -0400 Received: from prod-mail-xrelay02.akamai.com ([72.246.2.14]:38350 "EHLO prod-mail-xrelay02.akamai.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751110AbbEFR2t (ORCPT ); Wed, 6 May 2015 13:28:49 -0400 Message-ID: <554A4F50.6080208@akamai.com> Date: Wed, 06 May 2015 13:28:48 -0400 From: Sri User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Shuah Khan CC: Andrew Morton , Eric B Munson , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH V2] Test compaction of mlocked memory References: <1429813301-27216-1-git-send-email-sjayaram@akamai.com> <20150423184134.GF2282@akamai.com> <20150423132323.a3bd1dcdc94a2da3ca06a30d@linux-foundation.org> <553954FC.4050700@osg.samsung.com> <554A4904.4040604@osg.samsung.com> In-Reply-To: <554A4904.4040604@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2570 Lines: 85 Hi Shuah, This is what I see when I check the patch against the script, linux-stable$ ./scripts/checkpatch.pl 0001-Test-compaction-of-mlocked-memory.patch WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #72: new file mode 100644 total: 0 errors, 1 warnings, 256 lines checked 0001-Test-compaction-of-mlocked-memory.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. That was the only warning I saw even before I submitted the patch. I'm not sure how the whitespaces are introduced... Thanks -Sri On 05/06/2015 01:01 PM, Shuah Khan wrote: > On 04/23/2015 02:24 PM, Shuah Khan wrote: >> On 04/23/2015 02:23 PM, Andrew Morton wrote: >>> On Thu, 23 Apr 2015 14:41:34 -0400 Eric B Munson wrote: >>> >>>> On Thu, 23 Apr 2015, Sri Jayaramappa wrote: >>>> >>>>> Commit commit 5bbe3547aa3b ("mm: allow compaction of unevictable pages") >>>>> introduced a sysctl that allows userspace to enable scanning of locked >>>>> pages for compaction. This patch introduces a new test which fragments >>>>> main memory and attempts to allocate a number of huge pages to exercise >>>>> this compaction logic. >>>>> >>>>> Tested on machines with up to 32 GB RAM. With the patch a much larger >>>>> number of huge pages can be allocated than on the kernel without the >>>>> patch. >>>>> >>>>> Example output: >>>>> On a machine with 16 GB RAM: >>>>> sudo make run_tests vm >>>>> ... >>>>> ----------------------- >>>>> running compaction_test >>>>> ----------------------- >>>>> No of huge pages allocated = 3834 >>>>> [PASS] >>>>> ... >>>>> >>>>> Signed-off-by: Sri Jayaramappa >>>>> Cc: linux-kernel@vger.kernel.org >>>>> Cc: linux-api@vger.kernel.org >>>>> Cc: Andrew Morton >>>>> Cc: Eric B Munson >>>> >>>> Reviewed-by: Eric B Munson >>> >>> Acked-by: Andrew Morton >>> >>> I'm assuming that Shuah will process this one? >>> >> >> Yes. I will get this one after the merge window closes. >> > > Hi Sri Jayaramappa, > > The patch didn't pass checkpatch. Several trailing whitespace > errors. Could you please fix these and resend. > > thanks, > -- Shuah > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/