Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752290AbbEFRr6 (ORCPT ); Wed, 6 May 2015 13:47:58 -0400 Received: from mail-by2on0114.outbound.protection.outlook.com ([207.46.100.114]:42006 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751703AbbEFRr4 (ORCPT ); Wed, 6 May 2015 13:47:56 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none; X-WSS-ID: 0NNXW3D-08-1C2-02 X-M-MSG: Message-ID: <554A53B7.5030201@amd.com> Date: Wed, 6 May 2015 12:47:35 -0500 From: Aravind Gopalakrishnan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Borislav Petkov CC: , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH V2 1/6] x86/MCE/AMD: Factor out logging mechanism References: <1430913538-1415-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1430913538-1415-2-git-send-email-Aravind.Gopalakrishnan@amd.com> <20150506174150.GH22949@pd.tnic> In-Reply-To: <20150506174150.GH22949@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(24454002)(377454003)(479174004)(51704005)(52604005)(199003)(189002)(50466002)(50986999)(76176999)(65816999)(54356999)(83506001)(106466001)(87936001)(62966003)(33656002)(80316001)(2950100001)(77156002)(86362001)(46102003)(101416001)(77096005)(23676002)(65956001)(47776003)(59896002)(120886001)(4001350100001)(189998001)(105586002)(36756003)(110136002)(92566002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR02MB072;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB072; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BN1PR02MB072;BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB072; X-Forefront-PRVS: 0568F32D91 X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2015 17:47:39.6717 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR02MB072 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 652 Lines: 27 On 5/6/2015 12:41 PM, Borislav Petkov wrote: > > Yeah, let's save us the mce_setup() work in the !MCI_STATUS_VAL case: > Sure, thanks for fixing it. > +static void __log_error(unsigned int bank, bool threshold_err, u64 misc) > +{ > + struct mce m; > + u64 status; > + > + rdmsrl(MSR_IA32_MCx_STATUS(bank), status); > + if (!(status & MCI_STATUS_VAL)) > + return; > + > + mce_setup(&m); > + > -Aravind. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/