Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751885AbbEFSKz (ORCPT ); Wed, 6 May 2015 14:10:55 -0400 Received: from mga03.intel.com ([134.134.136.65]:37393 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbbEFSKx (ORCPT ); Wed, 6 May 2015 14:10:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,380,1427785200"; d="scan'208";a="490200680" Date: Wed, 6 May 2015 11:09:08 -0700 (PDT) From: Vikas Shivappa X-X-Sender: vikas@vshiva-Udesk To: Peter Zijlstra cc: Vikas Shivappa , Vikas Shivappa , linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, tj@kernel.org, Matt Fleming , "Auld, Will" , peter.zijlstra@intel.com, h.peter.anvin@intel.com, "Juvva, Kanaka D" Subject: Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT In-Reply-To: <20150506081143.GV23123@twins.programming.kicks-ass.net> Message-ID: References: <1430530601-16319-1-git-send-email-vikas.shivappa@linux.intel.com> <1430530601-16319-4-git-send-email-vikas.shivappa@linux.intel.com> <20150502184610.GH3007@worktop.Skamania.guest> <20150506081143.GV23123@twins.programming.kicks-ass.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1033 Lines: 35 On Wed, 6 May 2015, Peter Zijlstra wrote: > On Mon, May 04, 2015 at 10:30:15AM -0700, Vikas Shivappa wrote: >> Will fix the whitespace issues (including before return) or other possible >> coding convention issues. >> >> It could be more of a common sense to have this in checkpatch rather that >> manually having to pointing out. If you want to have fun with that go for it >> though. > > My main objection was that your coding style is entirely inconsistent > with itself. > > Sometimes you have a whitespace before return, sometimes you do not. > > Sometimes you have exit labels with locks, sometimes you do not. > > etc.. > > Pick one stick to it; although we'd all much prefer if you pick the one > that's common to the kernel. Will fix the convention issues. Thanks, Vikas > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/