Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751846AbbEFTjC (ORCPT ); Wed, 6 May 2015 15:39:02 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:35555 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbbEFTi4 (ORCPT ); Wed, 6 May 2015 15:38:56 -0400 MIME-Version: 1.0 In-Reply-To: <20150506121311.GP22845@sirena.org.uk> References: <1430856941-3938-1-git-send-email-marek@goldelico.com> <20150506121311.GP22845@sirena.org.uk> Date: Wed, 6 May 2015 21:38:55 +0200 Message-ID: Subject: Re: [PATCH] ASoC: bt-sco: Add devicetree support for bt-sco codec From: Belisko Marek To: Mark Brown Cc: Liam Girdwood , perex@perex.cz, tiwai@suse.de, "devicetree@vger.kernel.org" , LKML , alsa-devel@alsa-project.org, "Dr. H. Nikolaus Schaller" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1306 Lines: 38 Hi Mark, On Wed, May 6, 2015 at 2:13 PM, Mark Brown wrote: > On Tue, May 05, 2015 at 10:15:41PM +0200, Marek Belisko wrote: > >> +static const struct of_device_id bt_sco_codec_of_match[] = { >> + { .compatible = "delta,dfbmcs320", }, >> + { .compatible = "linux,bt-sco", }, > > Is there any burning reason for adding the linux,bt-sco compatible? No no real reason just want to keep that if somebody would like use it from DT referenced by bt-sco entry (similar as platform data). I'm adding DT support for it because I want to use this for W2CBW003 chip and I can use simply "linux,bt-sco" property in DT or I instead of that add new vendor prefix + add new compatible entry which is IMO much harder that reference it by generic name. Thanks, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/