Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751576AbbEFUPM (ORCPT ); Wed, 6 May 2015 16:15:12 -0400 Received: from lists.s-osg.org ([54.187.51.154]:49936 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750930AbbEFUPJ (ORCPT ); Wed, 6 May 2015 16:15:09 -0400 Message-ID: <554A764C.7080908@osg.samsung.com> Date: Wed, 06 May 2015 14:15:08 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Zhang Zhen , linux-api@vger.kernel.org, "linux-kernel@vger.kernel.org >> Linux Kernel Mailing List" CC: "Eric W. Biederman" , Shuah Khan Subject: Re: [PATCH v2] selftests/mount: output WARN messages when mount test skipped References: <1428024818-28554-1-git-send-email-zhenzhang.zhang@huawei.com> <551DEF58.3090505@huawei.com> In-Reply-To: <551DEF58.3090505@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1875 Lines: 47 On 04/02/2015 07:39 PM, Zhang Zhen wrote: > Without this patch, if /proc/self/uid_map is not exist, > the mount test case will skipped and no any prompting. > > After applied this patch, the case will prompt why it skipped. > Just as follows: > root@kernel-host:/opt/kernel> make -C tools/testing/selftests TARGETS=mount run_tests > make: Entering directory `/opt/kernel/tools/testing/selftests' > for TARGET in mount; do \ > make -C $TARGET; \ > done; > make[1]: Entering directory `/opt/kernel/tools/testing/selftests/mount' > make[1]: Nothing to be done for `all'. > make[1]: Leaving directory `/opt/kernel/tools/testing/selftests/mount' > for TARGET in mount; do \ > make -C $TARGET run_tests; \ > done; > make[1]: Entering directory `/opt/kernel/tools/testing/selftests/mount' > if [ -f /proc/self/uid_map ] ; then ./unprivileged-remount-test ; else echo "WARN: No /proc/self/uid_map exist, test skipped." ; fi > WARN: No /proc/self/uid_map exist, test skipped. > make[1]: Leaving directory `/opt/kernel/tools/testing/selftests/mount' > make: Leaving directory `/opt/kernel/tools/testing/selftests' > > Change v1 -> v2: > - fix syntax error when run kselftest_install.sh > > Signed-off-by: Zhang Zhen > --- Thanks for fixing this. Applied it to linux-kselftest next for 4.2 - I ended up making changes the commit log to fix checkpatch warnings before applying the patch. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/