Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751971AbbEFXWU (ORCPT ); Wed, 6 May 2015 19:22:20 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:60789 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbbEFXWR (ORCPT ); Wed, 6 May 2015 19:22:17 -0400 Message-ID: <554AA221.4040000@hitachi.com> Date: Thu, 07 May 2015 08:22:09 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: ananth@in.ibm.com, Peter Zijlstra , hemant@linux.vnet.ibm.com, Linux Kernel Mailing List , David Ahern , namhyung@kernel.org, Jiri Olsa , Ingo Molnar Subject: Re: [PATCH perf/core 6/8] perf-probe: Add --no-inlines option to avoid searching inline functions References: <20150506124638.4961.3172.stgit@localhost.localdomain> <20150506124651.4961.11.stgit@localhost.localdomain> <20150506155236.GA7862@kernel.org> In-Reply-To: <20150506155236.GA7862@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1657 Lines: 41 On 2015/05/07 0:52, Arnaldo Carvalho de Melo wrote: > Em Wed, May 06, 2015 at 09:46:51PM +0900, Masami Hiramatsu escreveu: >> Add --no-inlines(--inlines) option to avoid searching inline >> functions. >> Searching all functions which matches glob pattern can take a >> long time and find a lot of inline functions. With this option >> perf-probe searches target on the non-inlined functions. >> >> >> ret = add_perf_probe_events(params.events, params.nevents, >> params.max_probe_points, >> - params.force_add); >> + params.force_add, >> + params.no_inlines); > > So, there is just one call to this function, and all the parameters come > from the 'param' struct, why not just pass it? Hm, the reason why I don't do that is for readability in util/probe-event.c side. Passing params to the callee involves - export params struct (not be static) - callee has to extract required parameters from params. - it makes obscure that what parameters will be used in the method. However, it seems that some of them would be better global configs like symbol_conf. I'd like to suggest to introduce probe_conf global config. Is it OK ? Thank you, -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/