Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752195AbbEFX3d (ORCPT ); Wed, 6 May 2015 19:29:33 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56440 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbbEFX3a (ORCPT ); Wed, 6 May 2015 19:29:30 -0400 Date: Wed, 6 May 2015 16:29:29 -0700 From: Andrew Morton To: Tony Luck Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm/memblock: Add extra "flag" to memblock to allow selection of memory based on attribute Message-Id: <20150506162929.f97cf487bd41686325f9da2f@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 27 On Wed, 29 Apr 2015 11:31:24 -0700 Tony Luck wrote: > No functional changes > > ... > > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -61,7 +61,7 @@ extern bool movable_node_enabled; > > phys_addr_t memblock_find_in_range_node(phys_addr_t size, phys_addr_t align, > phys_addr_t start, phys_addr_t end, > - int nid); > + int nid, u32 flag); Sometimes this is called "flag", other times it is called "flags". Can we please be consistent? "flags" seems to be the way to go. Also, memblock_region.flags has type unsigned long, but you've used u32. ulong seems better. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/