Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751638AbbEGAEv (ORCPT ); Wed, 6 May 2015 20:04:51 -0400 Received: from dresden.studentenwerk.mhn.de ([141.84.225.229]:45648 "EHLO email.studentenwerk.mhn.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbbEGAEt convert rfc822-to-8bit (ORCPT ); Wed, 6 May 2015 20:04:49 -0400 From: Wolfgang Walter To: Eric Dumazet Cc: Cong Wang , Vlad Yasevich , LKML , Hannes Frederic Sowa , Linux Kernel Network Developers Subject: Re: kernel >= 4.0: crashes when using traceroute6 with isatap Date: Thu, 07 May 2015 02:04:46 +0200 Message-ID: <357742496.VPxjz4tqdT@h2o.as.studentenwerk.mhn.de> User-Agent: KMail/4.14.2 (Linux/3.13.11-031311-generic; KDE/4.14.2; i686; ; ) In-Reply-To: <1430952158.14545.97.camel@edumazet-glaptop2.roam.corp.google.com> References: <1770409.aMESoOv08f@h2o.as.studentenwerk.mhn.de> <2723870.nq54KKjWkm@h2o.as.studentenwerk.mhn.de> <1430952158.14545.97.camel@edumazet-glaptop2.roam.corp.google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2239 Lines: 67 Am Mittwoch, 6. Mai 2015, 15:42:38 schrieben Sie: > On Thu, 2015-05-07 at 00:04 +0200, Wolfgang Walter wrote: > > Am Mittwoch, 6. Mai 2015, 12:10:00 schrieb Eric Dumazet: > > > On Wed, 2015-05-06 at 11:15 -0700, Cong Wang wrote: > > > > (Cc'ing netdev.) > > > > > > > > On Sat, May 2, 2015 at 5:29 AM, Wolfgang Walter wrote: > > > > > Am Samstag, 2. Mai 2015, 02:16:36 schrieb Wolfgang Walter: > > > > >> Hello, > > > > >> > > > > >> kernel 4.0 (and 4.0.1) crashes immediately when I use traceroute6 > > > > >> with > > > > >> an > > > > >> isatap-tunnel. > > > > > > > > > > I did some further tests. To trigger the crash you need > > > > > > > > > > * isatap-tunnel (probably any sit-tunnel will do it) > > > > > * raw-socket > > > > > * udp > > > > > > > > > > Using icmpv6 or tcp i.e. does not trigger it. > > > > > > > > Do you have a script to reproduce it? > > > > > > > > > > > > Thanks for the bug report! > > > > -- > > > > > > Please Wolfgang try to revert 32dce968dd987adfb0c00946d78dad9154f64759 > > > ("ipv6: Allow for partial checksums on non-ufo packets") > > > > Indeed, that fixes the problem. > > Yes, setting skb->csum to 0 is clearly wrong for CHECKSUM_PARTIAL > > Would you try : > > diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c > index > 7fde1f265c90e90f16291e6c861b6e242111c25b..694ae630e1ca67e25ab1e5f6dd0b3597d > b3669b0 100644 --- a/net/ipv6/ip6_output.c > +++ b/net/ipv6/ip6_output.c > @@ -1416,6 +1416,10 @@ alloc_new_skb: > data += fragheaderlen; > skb->transport_header = (skb->network_header + > fragheaderlen); > + if (csummode == CHECKSUM_PARTIAL) { > + skb->csum_start = skb_transport_header(skb) - skb->head; > + skb->csum_offset = offsetof(struct udphdr, check); > + } > if (fraggap) { > skb->csum = skb_copy_and_csum_bits( > skb_prev, maxfraglen, This patch fixes 4.0.1 (and 4.0.2). Thanks Eric, -- Wolfgang Walter Studentenwerk M?nchen Anstalt des ?ffentlichen Rechts -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/