Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751998AbbEGBNX (ORCPT ); Wed, 6 May 2015 21:13:23 -0400 Received: from TYO202.gate.nec.co.jp ([210.143.35.52]:35853 "EHLO tyo202.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285AbbEGBNP convert rfc822-to-8bit (ORCPT ); Wed, 6 May 2015 21:13:15 -0400 From: Naoya Horiguchi To: Xie XiuQi CC: "rostedt@goodmis.org" , "mingo@redhat.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "koct9i@gmail.com" , "hpa@linux.intel.com" , "hannes@cmpxchg.org" , "iamjoonsoo.kim@lge.com" , "luto@amacapital.net" , "nasa4836@gmail.com" , "gong.chen@linux.intel.com" , "bhelgaas@google.com" , "bp@suse.de" , "tony.luck@intel.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "jingle.chen@huawei.com" Subject: Re: [PATCH v4 2/3] memory-failure: change type of action_result's param 3 to enum Thread-Topic: [PATCH v4 2/3] memory-failure: change type of action_result's param 3 to enum Thread-Index: AQHQiFn2qHFrOt1yckaMVi6Ap6+6RA== Date: Thu, 7 May 2015 00:08:35 +0000 Message-ID: <20150507000835.GA2954@hori1.linux.bs1.fc.nec.co.jp> References: <1429519480-11687-1-git-send-email-xiexiuqi@huawei.com> <1429519480-11687-3-git-send-email-xiexiuqi@huawei.com> In-Reply-To: <1429519480-11687-3-git-send-email-xiexiuqi@huawei.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.128.101.3] Content-Type: text/plain; charset="iso-2022-jp" Content-ID: <0CE1F142B620854BB8BB74912BD45A5B@gisp.nec.co.jp> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1814 Lines: 47 On Mon, Apr 20, 2015 at 04:44:39PM +0800, Xie XiuQi wrote: > Change type of action_result's param 3 to enum for type consistency, > and rename mf_outcome to mf_result for clearly. > > Signed-off-by: Xie XiuQi Acked-by: Naoya Horiguchi > --- > include/linux/mm.h | 2 +- > mm/memory-failure.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 8413615..93c4a00 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2156,7 +2156,7 @@ extern int soft_offline_page(struct page *page, int flags); > /* > * Error handlers for various types of pages. > */ > -enum mf_outcome { > +enum mf_result { > MF_IGNORED, /* Error: cannot be handled */ > MF_FAILED, /* Error: handling failed */ > MF_DELAYED, /* Will be handled later */ > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 6f5748d..f074f8e 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -847,7 +847,8 @@ static struct page_state { > * "Dirty/Clean" indication is not 100% accurate due to the possibility of > * setting PG_dirty outside page lock. See also comment above set_page_dirty(). > */ > -static void action_result(unsigned long pfn, enum mf_action_page_type type, int result) > +static void action_result(unsigned long pfn, enum mf_action_page_type type, > + enum mf_result result) > { > pr_err("MCE %#lx: recovery action for %s: %s\n", > pfn, action_page_types[type], action_name[result]); > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/