Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752017AbbEGBET (ORCPT ); Wed, 6 May 2015 21:04:19 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.227]:29335 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750710AbbEGBER (ORCPT ); Wed, 6 May 2015 21:04:17 -0400 Date: Wed, 6 May 2015 21:04:28 -0400 From: Steven Rostedt To: Jiri Olsa Cc: Wang Nan , acme@redhat.com, lizefan@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tools lib traceevent: install libtraceevent.a into libdir. Message-ID: <20150506210428.7c399532@grimm.local.home> In-Reply-To: <20150506202915.GC15184@krava.redhat.com> References: <20150506070735.GA28202@krava.redhat.com> <1430906420-28288-1-git-send-email-wangnan0@huawei.com> <20150506202915.GC15184@krava.redhat.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.142:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1832 Lines: 61 On Wed, 6 May 2015 22:29:15 +0200 Jiri Olsa wrote: > On Wed, May 06, 2015 at 10:00:20AM +0000, Wang Nan wrote: > > Before this patch, 'make install' installs libraries into bindir: > > > > $ make install DESTDIR=./tree > > INSTALL trace_plugins > > INSTALL libtraceevent.a > > INSTALL libtraceevent.so > > $ find ./tree > > ./tree/ > > ./tree/usr > > ./tree/usr/local > > ./tree/usr/local/bin > > ./tree/usr/local/bin/libtraceevent.a > > ./tree/usr/local/bin/libtraceevent.so > > ... > > > > /usr/local/lib( or lib64) should be a better place. > > > > This patch replaces 'bin' with libdir. For __LP64__ building, libraries > > are installed to /usr/local/lib64. For other building, to > > /usr/local/lib instead. > > > > After applying this patch: > > > > $ make install DESTDIR=./tree > > INSTALL trace_plugins > > INSTALL libtraceevent.a > > INSTALL libtraceevent.so > > $ find ./tree > > ./tree > > ./tree/usr > > ./tree/usr/local > > ./tree/usr/local/lib64 > > ./tree/usr/local/lib64/libtraceevent.a > > ./tree/usr/local/lib64/traceevent > > ./tree/usr/local/lib64/traceevent/plugins > > ./tree/usr/local/lib64/traceevent/plugins/plugin_mac80211.so > > ./tree/usr/local/lib64/traceevent/plugins/plugin_hrtimer.so > > ... > > ./tree/usr/local/lib64/libtraceevent.so > > > > Signed-off-by: Wang Nan > > Acked-by: Jiri Olsa > > CC-ing Steven > Thanks, looks fine to me. Acked-by: Steven Rostedt -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/