Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751622AbbEGBNH (ORCPT ); Wed, 6 May 2015 21:13:07 -0400 Received: from TYO201.gate.nec.co.jp ([210.143.35.51]:34869 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbbEGBNE convert rfc822-to-8bit (ORCPT ); Wed, 6 May 2015 21:13:04 -0400 From: Naoya Horiguchi To: Xie XiuQi , "rostedt@goodmis.org" , "akpm@linux-foundation.org" CC: "mingo@redhat.com" , "kirill.shutemov@linux.intel.com" , "koct9i@gmail.com" , "hpa@linux.intel.com" , "hannes@cmpxchg.org" , "iamjoonsoo.kim@lge.com" , "luto@amacapital.net" , "nasa4836@gmail.com" , "gong.chen@linux.intel.com" , "bhelgaas@google.com" , "bp@suse.de" , "tony.luck@intel.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "jingle.chen@huawei.com" Subject: Re: [PATCH v4 0/3] tracing: add trace event for memory-failure Thread-Topic: [PATCH v4 0/3] tracing: add trace event for memory-failure Thread-Index: AQHQgm3JnDm6jt6SNEekdx8PnpJwuZ1vKfCA Date: Thu, 7 May 2015 01:12:07 +0000 Message-ID: <20150507011207.GC7745@hori1.linux.bs1.fc.nec.co.jp> References: <1429519480-11687-1-git-send-email-xiexiuqi@huawei.com> <5540BD13.1010408@huawei.com> In-Reply-To: <5540BD13.1010408@huawei.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.128.101.3] Content-Type: text/plain; charset="iso-2022-jp" Content-ID: <5CE273A685D82A4B8C45C001FCCEE05B@gisp.nec.co.jp> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2866 Lines: 76 On Wed, Apr 29, 2015 at 07:14:27PM +0800, Xie XiuQi wrote: > Hi Naoya, > > Could you help to review and applied this series if possible. Sorry for late response, I was offline for several days due to national holidays. This patchset is good to me, but I'm not sure which path it should go through. Ordinarily, memory-failure patches go to linux-mm, but patch 3 depends on TRACE_DEFINE_ENUM patches, so this can go to linux-next directly, or go to linux-mm with depending patches. Steven, Andrew, which way do you like? Thanks, Naoya Horiguchi > Thanks, > Xie XiuQi > > On 2015/4/20 16:44, Xie XiuQi wrote: > > RAS user space tools like rasdaemon which base on trace event, could > > receive mce error event, but no memory recovery result event. So, I > > want to add this event to make this scenario complete. > > > > This patchset add a event at ras group for memory-failure. > > > > The output like below: > > # tracer: nop > > # > > # entries-in-buffer/entries-written: 2/2 #P:24 > > # > > # _-----=> irqs-off > > # / _----=> need-resched > > # | / _---=> hardirq/softirq > > # || / _--=> preempt-depth > > # ||| / delay > > # TASK-PID CPU# |||| TIMESTAMP FUNCTION > > # | | | |||| | | > > mce-inject-13150 [001] .... 277.019359: memory_failure_event: pfn 0x19869: recovery action for free buddy page: Delayed > > > > -- > > v3->v4: > > - rebase on top of latest linux-next > > - update comments as Naoya's suggestion > > - add #ifdef CONFIG_MEMORY_FAILURE for this trace event > > - change type of action_result's param 3 to enum > > > > v2->v3: > > - rebase on top of linux-next > > - based on Steven Rostedt's "tracing: Add TRACE_DEFINE_ENUM() macro > > to map enums to their values" patch set v1. > > > > v1->v2: > > - Comment update > > - Just passing 'result' instead of 'action_name[result]', > > suggested by Steve. And hard coded there because trace-cmd > > and perf do not have a way to process enums. > > > > Xie XiuQi (3): > > memory-failure: export page_type and action result > > memory-failure: change type of action_result's param 3 to enum > > tracing: add trace event for memory-failure > > > > include/linux/mm.h | 34 ++++++++++ > > include/ras/ras_event.h | 85 ++++++++++++++++++++++++ > > mm/memory-failure.c | 172 ++++++++++++++++++++---------------------------- > > 3 files changed, 190 insertions(+), 101 deletions(-) > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/