Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751576AbbEGDhI (ORCPT ); Wed, 6 May 2015 23:37:08 -0400 Received: from g4t3425.houston.hp.com ([15.201.208.53]:60793 "EHLO g4t3425.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbbEGDhF convert rfc822-to-8bit (ORCPT ); Wed, 6 May 2015 23:37:05 -0400 From: "Elliott, Robert (Server Storage)" To: "Luis R. Rodriguez" , "bp@suse.de" , "mingo@elte.hu" , "tglx@linutronix.de" , "hpa@zytor.com" , "plagnioj@jcrosoft.com" , "tomi.valkeinen@ti.com" , "daniel.vetter@intel.com" , "airlied@linux.ie" CC: "dledford@redhat.com" , "awalls@md.metrocast.net" , "syrjala@sci.fi" , "luto@amacapital.net" , "mst@redhat.com" , "cocci@systeme.lip6.fr" , "linux-kernel@vger.kernel.org" , "Luis R. Rodriguez" , Juergen Gross , Daniel Vetter , Dave Airlie , Bjorn Helgaas , "x86@kernel.org" Subject: RE: [PATCH v5 1/6] x86/mm/pat: use pr_info() and friends Thread-Topic: [PATCH v5 1/6] x86/mm/pat: use pr_info() and friends Thread-Index: AQHQg4Ruw/bCKsDxSUmqaRrVxbKMTZ1v5Oeg Date: Thu, 7 May 2015 03:36:15 +0000 Message-ID: <94D0CD8314A33A4D9D801C0FE68B40295A8E3CFF@G4W3202.americas.hpqcorp.net> References: <1430425520-22275-1-git-send-email-mcgrof@do-not-panic.com> <1430425520-22275-2-git-send-email-mcgrof@do-not-panic.com> In-Reply-To: <1430425520-22275-2-git-send-email-mcgrof@do-not-panic.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.210.192.232] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1335 Lines: 37 > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- > owner@vger.kernel.org] On Behalf Of Luis R. Rodriguez > Sent: Thursday, April 30, 2015 3:25 PM > Subject: [PATCH v5 1/6] x86/mm/pat: use pr_info() and friends > ... > - printk(KERN_ERR "%s:%d map pfn expected mapping > type %s" > - " for [mem %#010Lx-%#010Lx], got %s\n", > - current->comm, current->pid, > - cattr_name(want_pcm), > - (unsigned long long)paddr, > - (unsigned long long)(paddr + size - 1), > - cattr_name(pcm)); > + pr_err("%s:%d map pfn expected mapping type %s" > + " for [mem %#010Lx-%#010Lx], got %s\n", Since the patch joins some other print format strings split across lines (which checkpatch allows), you might want to join this one too. ... > diff --git a/arch/x86/mm/pat_rbtree.c b/arch/x86/mm/pat_rbtree.c ... > failure: > - printk(KERN_INFO "%s:%d conflicting memory types " > + pr_info("%s:%d conflicting memory types " > "%Lx-%Lx %s<->%s\n", current->comm, current->pid, start, > end, cattr_name(found_type), cattr_name(match->type)); and that one. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/