Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751957AbbEGEgP (ORCPT ); Thu, 7 May 2015 00:36:15 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:55897 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755AbbEGEgM (ORCPT ); Thu, 7 May 2015 00:36:12 -0400 Date: Thu, 7 May 2015 13:36:07 +0900 From: Simon Horman To: Stephen Boyd Cc: Mike Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Takashi Yoshii , Magnus Damm Subject: Re: [PATCH 09/19] clk: emev2: Silence sparse warnings Message-ID: <20150507043607.GI28846@verge.net.au> References: <1430897996-11597-1-git-send-email-sboyd@codeaurora.org> <1430897996-11597-10-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430897996-11597-10-git-send-email-sboyd@codeaurora.org> Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1377 Lines: 38 On Wed, May 06, 2015 at 12:39:46AM -0700, Stephen Boyd wrote: > drivers/clk/shmobile/clk-emev2.c:37:14: warning: symbol 'smu_base' was not declared. Should it be static? > > Cc: Takashi Yoshii > Cc: Magnus Damm > Cc: Simon Horman > Signed-off-by: Stephen Boyd Acked-by: Simon Horman Stephen, I'm assuming that you or Mike will merge this. > --- > drivers/clk/shmobile/clk-emev2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/shmobile/clk-emev2.c b/drivers/clk/shmobile/clk-emev2.c > index 6c7c929c7765..5b60beb7d0eb 100644 > --- a/drivers/clk/shmobile/clk-emev2.c > +++ b/drivers/clk/shmobile/clk-emev2.c > @@ -34,7 +34,7 @@ > static DEFINE_SPINLOCK(lock); > > /* not pretty, but hey */ > -void __iomem *smu_base; > +static void __iomem *smu_base; > > static void __init emev2_smu_write(unsigned long value, int offs) > { > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/