Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751925AbbEGH0I (ORCPT ); Thu, 7 May 2015 03:26:08 -0400 Received: from verein.lst.de ([213.95.11.211]:52612 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843AbbEGH0F (ORCPT ); Thu, 7 May 2015 03:26:05 -0400 Date: Thu, 7 May 2015 09:26:02 +0200 From: Christoph Hellwig To: Ross Zwisler Cc: Christoph Hellwig , linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, boaz@plexistor.com, axboe@kernel.dk Subject: Re: [PATCH 1/3] pmem: Initial version of persistent memory driver Message-ID: <20150507072602.GA23239@lst.de> References: <1427299449-26722-1-git-send-email-hch@lst.de> <1427299449-26722-2-git-send-email-hch@lst.de> <1427314913.14654.1.camel@theros.lm.intel.com> <20150326080656.GE26540@lst.de> <1430757781.5434.6.camel@theros.lm.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430757781.5434.6.camel@theros.lm.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 18 On Mon, May 04, 2015 at 10:43:01AM -0600, Ross Zwisler wrote: > > Yes, if CONFIG_DEBUG_BLOCK_EXT_DEVT isn't set that code doesn't work at all. > > I can't figure out a use case that breaks when using dynamically allocated > minors without CONFIG_DEBUG_BLOCK_EXT_DEVT. The patch that I've been testing > against is at the bottom of this mail. > > Here are the minors that I get when creating a bunch of partitions using the > current code with PMEM_MINORS=16, with CONFIG_DEBUG_BLOCK_EXT_DEVT turned off: FYI, your patch below works fine for me, but the original one certainly didn't. One big difference was that it also removed the register_blkdev call and thus assigning a major number. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/