Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbbEGHhg (ORCPT ); Thu, 7 May 2015 03:37:36 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:36555 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbbEGHhN (ORCPT ); Thu, 7 May 2015 03:37:13 -0400 Date: Thu, 7 May 2015 08:37:08 +0100 From: Lee Jones To: Geert Uytterhoeven Cc: Linus Walleij , Alexandre Courbot , Arnd Bergmann , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jingoo Han , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org Subject: Re: [PATCH 23/27] backlight: Allow compile test of GPIO consumers if !GPIOLIB Message-ID: <20150507073708.GA12484@x1> References: <1430836404-15513-1-git-send-email-geert@linux-m68k.org> <1430843563-18615-1-git-send-email-geert@linux-m68k.org> <1430843563-18615-23-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1430843563-18615-23-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2329 Lines: 64 On Tue, 05 May 2015, Geert Uytterhoeven wrote: > The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is > not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer > functionality only, can still be compiled if GPIOLIB is not enabled. > > Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where > appropriate. > > Signed-off-by: Geert Uytterhoeven > Cc: Jingoo Han > Cc: Lee Jones > Cc: Jean-Christophe Plagniol-Villard > Cc: Tomi Valkeinen > Cc: linux-fbdev@vger.kernel.org > --- > drivers/video/backlight/Kconfig | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Looks good. Applied, thanks. > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index 2d9923a60076e380..0505b796d743250e 100644 > --- a/drivers/video/backlight/Kconfig > +++ b/drivers/video/backlight/Kconfig > @@ -36,14 +36,16 @@ config LCD_CORGI > > config LCD_L4F00242T03 > tristate "Epson L4F00242T03 LCD" > - depends on SPI_MASTER && GPIOLIB > + depends on SPI_MASTER > + depends on GPIOLIB || COMPILE_TEST > help > SPI driver for Epson L4F00242T03. This provides basic support > for init and powering the LCD up/down through a sysfs interface. > > config LCD_LMS283GF05 > tristate "Samsung LMS283GF05 LCD" > - depends on SPI_MASTER && GPIOLIB > + depends on SPI_MASTER > + depends on GPIOLIB || COMPILE_TEST > help > SPI driver for Samsung LMS283GF05. This provides basic support > for powering the LCD up/down through a sysfs interface. > @@ -434,7 +436,7 @@ config BACKLIGHT_AS3711 > > config BACKLIGHT_GPIO > tristate "Generic GPIO based Backlight Driver" > - depends on GPIOLIB > + depends on GPIOLIB || COMPILE_TEST > help > If you have a LCD backlight adjustable by GPIO, say Y to enable > this driver. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/