Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751643AbbEGILI (ORCPT ); Thu, 7 May 2015 04:11:08 -0400 Received: from lb2-smtp-cloud3.xs4all.net ([194.109.24.26]:37818 "EHLO lb2-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751578AbbEGILB (ORCPT ); Thu, 7 May 2015 04:11:01 -0400 Message-ID: <1430986247.8171.37.camel@x220> Subject: Re: [PATCH 3/6] pinctrl: sunxi: Add H3 PIO controller support From: Paul Bolle To: Jens Kuske Cc: Maxime Ripard , Emilio =?ISO-8859-1?Q?L=F3pez?= , Mike Turquette , Linus Walleij , Vinod Koul , Rob Herring , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Date: Thu, 07 May 2015 10:10:47 +0200 In-Reply-To: <1430904693-1404-4-git-send-email-jenskuske@gmail.com> References: <1430904693-1404-1-git-send-email-jenskuske@gmail.com> <1430904693-1404-4-git-send-email-jenskuske@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1231 Lines: 43 On Wed, 2015-05-06 at 11:31 +0200, Jens Kuske wrote: > --- a/drivers/pinctrl/sunxi/Kconfig > +++ b/drivers/pinctrl/sunxi/Kconfig > +config PINCTRL_SUN8I_H3 > + def_bool MACH_SUN8I > + select PINCTRL_SUNXI_COMMON > --- a/drivers/pinctrl/sunxi/Makefile > +++ b/drivers/pinctrl/sunxi/Makefile > +obj-$(CONFIG_PINCTRL_SUN8I_H3) += pinctrl-sun8i-h3.o PINCTRL_SUN8I_H3 is a bool symbol, so pinctrl-sun8i-h3.o will never be part of a module, right? (Note that PINCTRL_SUN8I_H3 appears to be an alias for MACH_SUN8I. Ie, these two symbols operate in lockstep.) > --- /dev/null > +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c > +#include > +MODULE_DEVICE_TABLE(of, sun8i_h3_pinctrl_match); > +MODULE_AUTHOR("Jens Kuske "); > +MODULE_DESCRIPTION("Allwinner H3 pinctrl driver"); > +MODULE_LICENSE("GPL"); This adds some module specific boilerplate. Was it perhaps your intention to make PINCTRL_SUN8I_H3 a tristate symbol? Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/