From: Namjae Jeon <namjae.jeon@samsung.com>
To: "'Michael Kerrisk (man-pages)'" <mtk.manpages@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-man@vger.kernel.org, "'Linux API'" <linux-api@vger.kernel.org>,
        "'Dave Chinner'" <david@fromorbit.com>,
        "'Theodore Ts'o'" <tytso@mit.edu>
References: <006d01d08884$dcfc7ea0$96f57be0$@samsung.com>
 <554B2011.5010703@gmail.com>
In-reply-to: <554B2011.5010703@gmail.com>
Subject: RE: [PATCH v2] manpage: update FALLOC_FL_INSERT_RANGE flag in fallocate
Date: Thu, 07 May 2015 17:29:10 +0900
Message-id: <00be01d0889f$e427de20$ac779a60$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Thread-index: AQEtJrgdGrDdDSsmJ/4L08ky39yttwDqLBmVnq+gFkA=
Content-language: ko
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2381
Lines: 82

> Hello Namjae Jeon,
Hi Michael,
> 
> Thanks for the revised patch. I have a question below:
> 
> On 05/07/2015 07:15 AM, Namjae Jeon wrote:
> > Update FALLOC_FL_INSERT_RANGE flag in fallocate.
> >
> > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
> > ---
> >  man2/fallocate.2 | 89 ++++++++++++++++++++++++++++++++++++++++++++++++++++----
> >  1 file changed, 84 insertions(+), 5 deletions(-)
> >
> > diff --git a/man2/fallocate.2 b/man2/fallocate.2
> > index 0cc1a00..0d31027 100644
> > --- a/man2/fallocate.2
> > +++ b/man2/fallocate.2
> > @@ -228,6 +228,59 @@ ext4, for extent-based files (since Linux 3.15)
> >  .IP *
> >  SMB3 (since Linux 3.17)
> >  .\" commit 30175628bf7f521e9ee31ac98fa6d6fe7441a556
> > +.SS Increasing file space
> > +flag (available since Linux 4.1)
> > +.\" commit dd46c787788d5bf5b974729d43e4c405814a4c7d
> > +Specifying the
> > +.BR FALLOC_FL_INSERT_RANGE
> > +flag in
> > +.I mode
> > +will increase the file space by inserting a hole within the file size without
> > +overwriting any existing data.
> > +The hole will start at
> > +.I offset
> > +and continue for
> > +.I len
> > +bytes.
> > +For inserting hole inside file, the contents of the file starting at
> > +.I offset
> > +will be shifted towards right by
> > +.I len
> > +bytes.
> > +Inserting a hole inside the file will increase the file size by
> > +.I len
> > +bytes.
> > +
> > +This mode has the same limitation as
> > +.BR FALLOC_FL_COLLAPSE_RANGE
> > +regarding the
> > +granularity of the operation.
> > +If the granularity requirements are not met,
> > +.BR fallocate ()
> > +will fail with the error
> > +.BR EINVAL.
> > +If the
> > +.I offset
> > +overlaps with end of file OR if it is greater than end of file, an error is
> 
> 
> Could that last line not be simplified to
> 
>    if the offset is greater than or equal to the end of file
> 
> ?
Yes, Looks good :)

Thanks!!
> 
> Thanks,
> 
> Michael
> 
> 
> --
> Michael Kerrisk
> Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
> Linux/UNIX System Programming Training: http://man7.org/training/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/