Message-ID: <1430993477.30151.6.camel@suse.de>
Subject: Re: [PATCH] net: usb: allow MTU that is a multiple of USB packet
 size
From: Oliver Neukum <oneukum@suse.de>
To: Ruslan Bilovol <ruslan.bilovol@gmail.com>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Thu, 07 May 2015 12:11:17 +0200
In-Reply-To: <1430992159-27783-1-git-send-email-ruslan.bilovol@gmail.com>
References: <1430992159-27783-1-git-send-email-ruslan.bilovol@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 742
Lines: 21

On Thu, 2015-05-07 at 12:49 +0300, Ruslan Bilovol wrote:
> Current usbnet driver rejects setting MTU that is a multiple
> of USB endpoint's wMaxPacketSize size. However, it may only
> lead to possible performance degradation but is not so
> critical that its using should be prohibited. So allow it
> but also warn user about possible issue.

We have reports about devices reacting badly to ZLPs.
Unless you have a compelling reasons for this change
I have to reject it.

	Regards
		Oliver

NACK

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/