Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754729AbbEGKcR (ORCPT ); Thu, 7 May 2015 06:32:17 -0400 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:45058 "EHLO e28smtp09.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753815AbbEGKcN (ORCPT ); Thu, 7 May 2015 06:32:13 -0400 Date: Thu, 7 May 2015 16:02:02 +0530 From: Srikar Dronamraju To: Oleg Nesterov Cc: Ananth N Mavinakayanahalli , Anton Arapov , David Long , Denys Vlasenko , "Frank Ch. Eigler" , Ingo Molnar , Jan Willeke , Jim Keniston , Mark Wielaard , Pratyush Anand , linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/10] uprobes: Change prepare_uretprobe() to use uprobe_warn() Message-ID: <20150507103202.GA30396@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20150504124835.GA22462@redhat.com> <20150504124902.GA22495@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20150504124902.GA22495@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15050710-0033-0000-0000-000005964461 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 682 Lines: 27 * Oleg Nesterov [2015-05-04 14:49:02]: > Turn the last pr_warn() in uprobes.c into uprobe_warn(). > > While at it: > > - s/kzalloc/kmalloc, we initialize every member of ri > > - remove the pointless comment above the obvious code > > Signed-off-by: Oleg Nesterov Looks good to me. Acked-by: Srikar Dronamraju > --- -- Thanks and Regards Srikar Dronamraju -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/