Date: Thu, 7 May 2015 12:33:42 +0200
From: Andi Kleen <andi@firstfloor.org>
To: Kan Liang <kan.liang@intel.com>
Cc: peterz@infradead.org, mingo@kernel.org, acme@infradead.org,
        eranian@google.com, andi@firstfloor.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V8 8/8] perf tools: handle PERF_RECORD_LOST_SAMPLES
Message-ID: <20150507103342.GO2366@two.firstfloor.org>
References: <1430940834-8964-1-git-send-email-kan.liang@intel.com>
 <1430940834-8964-9-git-send-email-kan.liang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1430940834-8964-9-git-send-email-kan.liang@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1070
Lines: 26

On Wed, May 06, 2015 at 03:33:54PM -0400, Kan Liang wrote:
> From: Kan Liang <kan.liang@intel.com>
> 
> This patch modified the perf tool to handle the new RECORD type,
> PERF_RECORD_LOST_SAMPLES.
> The number of lost-sample events is stored in
> .nr_events[PERF_EVENT_LOST_SAMPLES]. While the exact number of samples
> which the kernel dropped is stored in total_lost_samples.
> When the percentage of dropped samples is greater than 5%, a warning
> will be sent out.

That's nice. Would be good to also print this in perf report --stdio
output (without -D), like the samples are.

Could you please do the same for the normal PERF_RECORD_LOST too?
There we don't have a exact percentage, but at least could count the
lost events too. This can be a separate patch of course, doesn't need
to be tied to this patchkit.


-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/