Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752935AbbEGLBZ (ORCPT ); Thu, 7 May 2015 07:01:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53135 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752250AbbEGLBW (ORCPT ); Thu, 7 May 2015 07:01:22 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <554A06FF.2090507@suse.cz> References: <554A06FF.2090507@suse.cz> <1430516505-4812-1-git-send-email-aricart@memnix.com> <1430559977.5803.12.camel@memnix.com> <5548E02A.5050006@suse.cz> To: Michal Marek Cc: dhowells@redhat.com, Linus Torvalds , Abelardo Ricart III , Linux Kernel Mailing List , Sedat Dilek , keyrings@linux-nfs.org, Rusty Russell , LSM List , James Morris , Greg Kroah-Hartman Subject: Re: [PATCH] MODSIGN: Change default key details [ver #2] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <9364.1430996458.1@warthog.procyon.org.uk> Date: Thu, 07 May 2015 12:00:58 +0100 Message-ID: <9365.1430996458@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 844 Lines: 21 Michal Marek wrote: > are you fine with these two patches? > > https://lkml.org/lkml/2015/2/20/546 > https://lkml.org/lkml/2015/5/4/614 Yeah, I think so. Your reasoning on the first one is sound - but is it possible for $(objtree) to != $(srctree) even when they're coincident. I like Linus's use of the filechk macro on the second - but we shouldn't overwrite keys someone has manually placed in the tree if the key generation template changes due to git pull altering kernel/Makefile. Sometimes I think makescript is like trying to program in Prolog - but worse. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/