Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752681AbbEGLIX (ORCPT ); Thu, 7 May 2015 07:08:23 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34092 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752288AbbEGLIV (ORCPT ); Thu, 7 May 2015 07:08:21 -0400 Message-ID: <1430996857.30151.8.camel@suse.de> Subject: Re: [PATCH] net: usb: allow MTU that is a multiple of USB packet size From: Oliver Neukum To: Ruslan Bilovol Cc: netdev , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Thu, 07 May 2015 13:07:37 +0200 In-Reply-To: References: <1430992159-27783-1-git-send-email-ruslan.bilovol@gmail.com> <1430993477.30151.6.camel@suse.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1426 Lines: 39 On Thu, 2015-05-07 at 13:51 +0300, Ruslan Bilovol wrote: > Hi Oliver, > > On Thu, May 7, 2015 at 1:11 PM, Oliver Neukum wrote: > > On Thu, 2015-05-07 at 12:49 +0300, Ruslan Bilovol wrote: > >> Current usbnet driver rejects setting MTU that is a multiple > >> of USB endpoint's wMaxPacketSize size. However, it may only > >> lead to possible performance degradation but is not so > >> critical that its using should be prohibited. So allow it > >> but also warn user about possible issue. > > > > We have reports about devices reacting badly to ZLPs. > > Unless you have a compelling reasons for this change > > I have to reject it. > > What devices do you mean here: USB network adapters or USB host controllers? The network adapters > If it's just network adapters, then we can create some kind of quirk handling > for them and do not disable this functionality just because some buggy device > can't work with it. No. They are too many. > My device works fine with ZLPs so I want to use this particular MTU under Linux > like I do it under other operation systems. We can have a white list, but the general case is just too dangerous. Sorry Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/