Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753367AbbEGLTW (ORCPT ); Thu, 7 May 2015 07:19:22 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:38094 "EHLO e28smtp07.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751358AbbEGLTQ (ORCPT ); Thu, 7 May 2015 07:19:16 -0400 Date: Thu, 7 May 2015 16:49:03 +0530 From: Srikar Dronamraju To: Oleg Nesterov Cc: Ananth N Mavinakayanahalli , Anton Arapov , David Long , Denys Vlasenko , "Frank Ch. Eigler" , Ingo Molnar , Jan Willeke , Jim Keniston , Mark Wielaard , Pratyush Anand , linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/10] uprobes: Change prepare_uretprobe() to (try to) flush the dead frames Message-ID: <20150507111903.GG30396@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20150504124835.GA22462@redhat.com> <20150504124922.GA22522@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20150504124922.GA22522@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15050711-0025-0000-0000-000004A350FF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 915 Lines: 26 * Oleg Nesterov [2015-05-04 14:49:22]: > Change prepare_uretprobe() to flush the !arch_uretprobe_is_alive() > return_instance's. This is not needed correctness-wise, but can help > to avoid the failure caused by MAX_URETPROBE_DEPTH. > > Note: in this case arch_uretprobe_is_alive() can be false positive, > the stack can grow after longjmp(). Unfortunately, the kernel can't > 100% solve this problem, but see the next patch. > > Signed-off-by: Oleg Nesterov > --- > kernel/events/uprobes.c | 13 +++++++++++++ Looks good to me. Acked-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/